If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Convert FrameMetrics.mScrollOffset to be a gfx::Point<CSSPixel>

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

23 Branch
mozilla24
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 756040 [details] [diff] [review]
Patch

Follow-up from bug 865735 - we is an incremental propagation of pixel-units information to some uses of gfx::Point, gfx::Size, and gfx::Rect.
Attachment #756040 - Flags: review?(ajones)
Assignee: nobody → bugmail.mozilla
Comment on attachment 756040 [details] [diff] [review]
Patch

Review of attachment 756040 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDisplayList.cpp
@@ +617,5 @@
>                                 const nsDisplayItem::ContainerParameters& aContainerParameters,
>                                 bool aMayHaveTouchListeners) {
>    nsPresContext* presContext = aForFrame->PresContext();
>    int32_t auPerDevPixel = presContext->AppUnitsPerDevPixel();
> +  int32_t auPerCSSPixel = nsPresContext::AppUnitsPerCSSPixel();

auPerCSSPixel is only used once so could be inlined
Attachment #756040 - Flags: review?(ajones) → review+
Landed with auPerCSSPixel inlined as requested:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb24851fd4a
https://hg.mozilla.org/mozilla-central/rev/5bb24851fd4a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.