877772 - Separate out MakeAPI from lib/project into a middleware step

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Chris DeCairos (:cade)]

The MakeAPI is killing some of the cornfield tests. There are two ways to fix this.

1. Fake it in the tests using webFaker
2. Make the use of it optional, similar to metrics, but a little more complex since it's not just a Fire and Forget API.

Comment 1

[Matthew Schranz [:mjschranz]]

Changing direction of ticket now that we have done a lot of big server rewrites.

After this we can then redo all of the cornfield tests!

Comment 2

[Matthew Schranz [:mjschranz]]

WIP - https://github.com/mozilla/popcorn.webmaker.org/pull/80

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/80

Quick first crack at this.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 768126 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/80

I'm not opposed to switching up the order that this is taking place to go MakeAPI -> Project Create/Update.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 768126 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/80

A nit and some commented out code needs to be removed.

I wonder if Cade wants to take a quick look at this as he filed it? Your call. 

R+ with those fixes.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/f5300fbd1a064ff8dc8f2a9e1cdae311be725e2c
Fix Bug 877772 - Separate out MakeAPI publishing into it's own middleware step