877778 - Browser Console, clicking JS/CSS error/warning link does not open source file

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/e58336e81395
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130529 Firefox/24.0 ID:20130529031131

Steps to Reproduce:
1. Open Browser Console
2. Open web page 
   ex. https://developer.mozilla.org/en-US/docs/Code_snippets
3. Click JS/CSS error/warning link

Actual Results:
Nothing happens.

Expected Results:
Source file should be opened and the error line should be selected.

Comment 1

[Girish Sharma [:Optimizer]]

This error is seen in browser console when you try to do so. :

--
[00:06:46.178] TypeError: this.hostTab is undefined @ resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox-hosts.js:49

Comment 2

[Mihai Sucan [:msucan]]

Thank you for the bug report.

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed patch

The problem was with the code for viewing the source of stylesheets. Fixed it and included a test that checks if clicking JS errors and CSS warnings works as expected.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=6eea5b22c6f3

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/cb1945196981

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/cb1945196981