877808 - Plug remixed from into make details page

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Scott [:thecount] Downe]

bug 875580 is landing the makedetails page without a remixed from display.

We're landing it in parts because it is blocked by bug 876441

The remixed from part has placeholder data at the moment.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/104

Comment 2

[Pomax]

Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

comments in pull request

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

Fixes.

Comment 4

[Pomax]

Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

few notes in the pull request - also, how can I test this with real data injected? I tried a publish, but its detail view seemed uninstantiated.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

Updates.

Comment 6

[Pomax]

Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

I've got nothing left to complain about =)

Comment 7

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/08c37dfbbddb53c48c9d15cc6cf1d06df1fd89b6