Plug remixed from into make details page

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 875580 is landing the makedetails page without a remixed from display.

We're landing it in parts because it is blocked by bug 876441

The remixed from part has placeholder data at the moment.
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
Depends on: 876441
(Assignee)

Comment 1

5 years ago
Created attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104
Attachment #760173 - Flags: review?(pomax)
Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

comments in pull request
Attachment #760173 - Flags: review?(pomax) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

Fixes.
Attachment #760173 - Flags: review- → review?(pomax)
Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

few notes in the pull request - also, how can I test this with real data injected? I tried a publish, but its detail view seemed uninstantiated.
Attachment #760173 - Flags: review?(pomax) → review-
(Assignee)

Comment 5

5 years ago
Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

Updates.
Attachment #760173 - Flags: review- → review?(pomax)
Comment on attachment 760173 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/104

I've got nothing left to complain about =)
Attachment #760173 - Flags: review?(pomax) → review+
(Assignee)

Comment 7

5 years ago
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/08c37dfbbddb53c48c9d15cc6cf1d06df1fd89b6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.