877816 - build failing with: format not a string literal and no format arguments [-Werror=format-security]

Status: UNCONFIRMED

(Firefox Build System :: General, defect)

Description

[AL]

Attachment: buildlog_ubuntu-raring-amd64.firefox-trunk_24.0~a1~hg20130529r133270-0ubuntu1~umd1~raring_FAILEDTOBUILD.txt.gz

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512193848

Steps to reproduce:

Recent nightly builds are no longer working with https://launchpad.net/~ubuntu-mozilla-daily/+archive/ppa






Actual results:

If you check a recent build log: https://launchpadlibrarian.net/141072403/buildlog_ubuntu-raring-amd64.firefox-trunk_24.0~a1~hg20130529r133270-0ubuntu1~umd1~raring_FAILEDTOBUILD.txt.gz

this is due to a flag that harshly enforces format warnings (format not a string literal and no format arguments [-Werror=format-security])


Expected results:

There are four places right now where this format error happens:
gfx/layers/composite/ContentHost.cpp:222:27
gfx/layers/composite/ContentHost.cpp:228:27
gfx/layers/composite/ContentHost.cpp:739:27
gfx/layers/composite/ContentHost.cpp:745:27

In all cases, there is a super simple fix. The code (in all four places) currently reads:
fprintf(aFile, "%s", aPrefix);

The warning/error stems from the fact that aPrefix may contain other %s characters, causing a problem.

Instead, use:
fputs(aPrefix, aFile);

and everything is fixed. I don't have mozilla-central cloned at the moment, otherwise I would have put together a patch myself.