877824 - log proper TEST-START and TEST-END points for reftests

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: log proper TEST-START and TEST-END points for reftests

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: log proper TEST-START and TEST-END points for reftests

This is a simple cosmetic change.  For parallelizing reftests, we're going to
execute subsets of the entire reftest suite and then merge the logs from those
subsets.  We need some way of identifying that a group of lines belong to a
single test so we can keep those lines together in the final merged log.  mochitests
and xpcshell tests already provide this with TEST-START and TEST-END messages.  This
patch makes reftests emit the same sort of messages.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 756171 [details] [diff] [review]
log proper TEST-START and TEST-END points for reftests

>-    gDumpLog("REFTEST TEST-START | Shutdown\n");
>+    gDumpLog("REFTEST INFO | Shutdown\n");

I think this change will probably break some tinderbox consumers, because we depend on bad things that happen during shutdown getting processed into failures that happen in the test "Shutdown" rather than failures that happen in whatever happens to be the last test.

r=dbaron if you drop this change or convince me it's not going to break that case

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d084b7d0f2e7