Closed
Bug 877859
Opened 11 years ago
Closed 11 years ago
B2G Gecko won't build with --enable-valgrind on master
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: qdot, Assigned: qdot)
References
Details
Attachments
(2 files, 2 obsolete files)
1.27 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
4.35 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Looks like I did all of my testing against b2g-18, not master, so we're missing a few includes that cause builds to fail when using --enable-valgrind. Just need to build a copy files step into our Android.mk for valgrind.
Assignee | ||
Updated•11 years ago
|
Blocks: b2g-valgrind
Assignee | ||
Comment 1•11 years ago
|
||
Patch against fxos branch of https://git.mozilla.org/b2g/valgrind Adds targets to copy headers, which will be run whenever B2G_VALGRIND flag is on. That way, we can make sure we always copy the newest version of the header. Currently only covers headers we actually need. Could also make it copy everything we expect from a normal installation?
Attachment #756238 -
Flags: review?(mwu)
Comment 2•11 years ago
|
||
Can we point gecko to the valgrind directory to find headers?
Assignee | ||
Comment 3•11 years ago
|
||
The header paths in the gecko source code expect the headers to be in valgrind/, as thats how the normal install process works. So, unfortunately, we can't without changing it across all platforms.
Comment 4•11 years ago
|
||
Comment on attachment 756238 [details] [diff] [review] Patch 1 (v1) - Add minimal header copy targets Rubberstamp since NPOTB
Attachment #756238 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Talked to mwu about copying files, seemed like a better idea to just make a patch with a special fxos includes directory for symlinks.
Attachment #756238 -
Attachment is obsolete: true
Attachment #764440 -
Flags: review?(mwu)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #764442 -
Flags: review?(mwu)
Updated•11 years ago
|
Attachment #764440 -
Flags: review?(mwu) → review+
Comment 7•11 years ago
|
||
Comment on attachment 764442 [details] [diff] [review] Patch 2 (v1) - Update gecko configure files for new FxOS valgrind include paths Review of attachment 764442 [details] [diff] [review]: ----------------------------------------------------------------- ::: CLOBBER @@ +17,4 @@ > # > # Modifying this file will now automatically clobber the buildbot machines \o/ > # > +Bug 877859 Valgrind header location updates for FxOS Valgrind Hmm, not sure if we need to clobber everyone for a developer only change. ::: configure.in @@ +204,4 @@ > > case "$ANDROID_VERSION" in > 15) > + GONK_INCLUDES="-I$gonkdir/frameworks/base/opengl/include -I$gonkdir/frameworks/base/native/include -I$gonkdir/frameworks/base/include -I$gonkdir/frameworks/base/services/camera -I$gonkdir/frameworks/base/include/media/stagefright -I$gonkdir/frameworks/base/include/media/stagefright/openmax -I$gonkdir/frameworks/base/media/libstagefright/rtsp -I$gonkdir/frameworks/base/media/libstagefright/include -I$gonkdir/external/dbus -I$gonkdir/external/bluetooth/bluez/lib -I$gonkdir/dalvik/libnativehelper/include/nativehelper -I$gonkdir/external/valgrind/fxos-include" I think we can just add valgrind to the full list of includes.
Assignee | ||
Comment 8•11 years ago
|
||
Moved the include to the full list instead of the version list. The clobber is necessary so I don't end up burning tbpl, which I did last time I tried this.
Attachment #764442 -
Attachment is obsolete: true
Attachment #764442 -
Flags: review?(mwu)
Attachment #764496 -
Flags: review?(mwu)
Updated•11 years ago
|
Attachment #764496 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/4e8ac15309c6
Assignee | ||
Comment 10•11 years ago
|
||
Patch 1 to valgrind repo: https://git.mozilla.org/?p=b2g/valgrind.git;a=commit;h=917ec1dc044f4dea2d5b5befbc596ed41fd22b83
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e8ac15309c6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•