Closed
Bug 877860
Opened 13 years ago
Closed 13 years ago
Make drop down navigation needs links to new app projects
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daleee, Assigned: alicoding)
Details
Attachments
(1 obsolete file)
We need URLs for:
- New Thimble
- New PM
- New X-Ray
for the submenu that appears when hovering over 'Make' on the nav bar.
Comment 1•13 years ago
|
||
For Thimble: https://thimble.webmaker.org/en-US/editor
For Popcorn Maker: https://popcorn.webmaker.org/templates/basic/
X-Ray Goggles: we're going to not include for June15th because we need to migrate publishing
| Assignee | ||
Comment 2•13 years ago
|
||
Just wanted to confirm as if I'm looking at the right place, and if so I will take this bug and do it as soon as possible.
https://github.com/mozilla/webmaker.org/blob/master/views/layout.html#L33
This will be for popcorn-maker
https://github.com/mozilla/webmaker.org/blob/master/views/layout.html#L39
This will be for thimble
https://github.com/mozilla/webmaker.org/blob/master/views/layout.html#L43
For X-Ray Goggles as :brett mentioned about I won't touch that part.
I will just need some confirmation then I will go ahead and do it
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ali
Status: NEW → ASSIGNED
| Assignee | ||
Comment 3•13 years ago
|
||
Attachment #757938 -
Flags: review?(me)
Attachment #757938 -
Flags: review?(kate)
| Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 757938 [details] [review]
https://github.com/mozilla/webmaker.org/pull/69
Fixed some CSS style on drop down item
Attachment #757938 -
Attachment filename: file_877860.txt → 69
Attachment #757938 -
Attachment is obsolete: true
Attachment #757938 -
Flags: review?(me)
Attachment #757938 -
Flags: review?(kate)
| Reporter | ||
Comment 5•13 years ago
|
||
r+wc, fix the build failure, rebase against latest master and then feel free to land it!
Comment 6•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/01552c20131cfc0023bdab258ed36ba4ca30e8ed
Merge pull request #69 from alicoding/bug877860
Added link the drop down navigation and remove x-ray goggles
| Reporter | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•