877925 - [balrog] Mac builds not offered a partial update

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

013-05-30 17:00:14,229 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#47: Got updateQuery: {'product': u'Firefox', 'buildID': u'20130529031131', 'locale': u'en-US', 'version': u'24.0a1', 'buildTarget': u'Darwin_x86_64-gcc3-u-i386-x86_64', 'distribution': u'default', 'osVersion': u'Darwin 12.3.0', 'channel': u'nightly', 'distVersion': u'default'}
2013-05-30 17:00:14,230 - PID: 11992 - Request: 2998010508 - Releases.getReleases#732: Looking for releases with:
2013-05-30 17:00:14,230 - PID: 11992 - Request: 2998010508 - Releases.getReleases#733: name: None
2013-05-30 17:00:14,231 - PID: 11992 - Request: 2998010508 - Releases.getReleases#734: product: Firefox
2013-05-30 17:00:14,232 - PID: 11992 - Request: 2998010508 - Releases.getReleases#735: version: 24.0a1
2013-05-30 17:00:37,841 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#53: Trying to match request to Firefox-mozilla-central-nightly-20130514031031
2013-05-30 17:00:37,843 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#53: Trying to match request to Firefox-mozilla-central-nightly-20130515031027
...
2013-05-30 17:00:37,855 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#53: Trying to match request to Firefox-mozilla-central-nightly-20130529031131
2013-05-30 17:00:37,855 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#53: Trying to match request to Firefox-mozilla-central-nightly-20130530031141
2013-05-30 17:00:37,856 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#53: Trying to match request to Firefox-mozilla-central-nightly-latest
2013-05-30 17:00:37,857 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#59: releasePlat buildID is: 20130530031141
...
2013-05-30 17:00:37,902 - PID: 11992 - Request: 2998010508 - AUS3.identifyRequest#63: Couldn't identify query

We should match against Firefox-mozilla-central-nightly-20130529031131 but don't ever get the buildID. Probably something to do with aliasing.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

There's no alias set in the blob for Firefox-mozilla-central-nightly-20130529031131, so getResolvedPlatfrom doesn't modify the buildTarget.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I wonder if we should put the hashFunction and standard mac alias in as default somehow, rather than just the bare release name at
 https://github.com/mozilla/balrog/blob/master/auslib/admin/views/releases.py#L100
eg an __init__ in ReleaseV1Blob().

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] send moar data to API

Teach the submitter to always send the hashFunction, and to send an alias if we know of more than one buildTarget.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [balrog] server side fixes

This creates aliases on submitting single locale data, I'm assuming that the submitter will do it all themselves if you're submitting a release wholesale. Also adds hashFunction if that has been specified when creating new releases (eg dated nightly), so also fixes bug 763004.

In the end I went for the slightly icky extraArgs to handle the case where the # of inputs to commitCallback() varying on the use case.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/41245053f96a484a246555182c0faa514ca6246f
Bug 877925, mac nightly builds not offered partials. Also fixes bug 763004, ensure hashFunction is set in blobs. r=bhearsum

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 765163 [details] [diff] [review]
[tools] send moar data to API

https://hg.mozilla.org/build/tools/rev/2dbbce60c859

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Got a partial today:

https://aus4-dev.allizom.org/update/3/Firefox/24.0a1/20130620031010/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/nightly/Darwin%2012.4.0/default/default/update.xml?force=1

<?xml version="1.0"?>
<updates>
    <update type="minor" version="24.0a1" extensionVersion="24.0a1" buildID="20130620113202">
        <patch type="complete" URL="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/06/2013-06-20-11-32-02-mozilla-central/firefox-24.0a1.en-US.mac.complete.mar" hashFunction="sha512" hashValue="29505cb54ee798bf6361dcd2eccf07699f2284e0f3909bd63c21d61549bf7296783dbd44eb2336663896670fbe03108efd719cf5c30855e6243f5bc05dbc175f" size="58440802"/>
        <patch type="partial" URL="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/06/2013-06-20-11-32-02-mozilla-central/firefox-24.0a1.en-US.mac.partial.20130620031010-20130620113202.mar" hashFunction="sha512" hashValue="8b6b7ca04bed0584eb9773826abfb4dd888e4e8b7af0233796fbdda42a27a30b87bedfec46bb4d6c8ff77d2ecc109e158dd0c04ae17a7ce5fa5b60710771d201" size="7136487"/>
    </update>
</updates>