877933 - Flickr tag/album feature doesn't always retrieve images

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jacob [:Jacob]]

Attachment: strange red highlight, dunno what it means

I have a project due for June 15th launch that is somewhat dependent on pulling from Flickr sets

https://popcorn.webmaker.org/templates/basic/index.html?savedDataUrl=/api/remix/51842

Sometimes it doesn't work, and the canvas is blank instead of scrolling through the images that it's supposed to.

A few things I noticed: 

1) this is mostly in the editor and it will work on export even though the editor isn't showing anything. I've seen the export not work sometimes but not as often.

2) The "Enter a Gallery URL" field sometimes is highlighted red. I have no idea what that means. (See attached screenshot)

3) I've discovered a workaround to get the images to display after they've disappeared.

If I have toggle "search for a tag", and then toggle back to ""Enter a Gallery URL" the images come back.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocker, as required for Jacob's June 15th work :/

Comment 2

[Brett Gaylor [:brett]]

Jacob, I can't reproduce - also, this project is awesome!

Can you see if this is still happening, and if not, remove this as a blocker?  It seems you're able to produce this make, so not sure this actually stops us from launching - though annoying.

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/50

I can't reproduce the albums not being loaded completely, but the red border around inputs is because browsers consider protocol less URLs with input elements of type url to be invalid.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 761556 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/50

I'm cool with removing the strange red highlight.

Sounds like there is another issue though, that was not reproduced yet.

We should have separate tickets to track the one that is not landing. r+ with a new ticket.

Comment 5

[Matthew Schranz [:mjschranz]]

Sure. This was just marked as blocking though so I want to clear it off the table.

Fine with this?

Comment 6

[Brett Gaylor [:brett]]

Up to jacob.

Comment 7

[Scott [:thecount] Downe]

I want to give this a try, see if I can reproduce it.

Comment 8

[Scott [:thecount] Downe]

I'm not seeing this fail either.

I tried a bunch of different browsers, and while there is a slight delay to load the images, less than a second, I'm not able to reproduce this in any significant way.

I also made a much smaller test case, which, is only valid if jacob can reproduce on it.

Jacon, can you get any issue using this: https://popcorn.webmaker.org/templates/basic/index.html?savedDataUrl=/api/remix/53867

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/d130e4b8ee6deabd09b9238539160519aa05a618
Fix Bug 877933 - Prevent browsers considering protocol less URLs in input type=url being considered invalid

Comment 10

[Matthew Schranz [:mjschranz]]

We want to keep this open for now.

Comment 11

[Pomax]

This ticket already landed code, so this has been resolved. If there is a followup issue, please file a new ticket