Closed Bug 877934 Opened 11 years ago Closed 11 years ago

ReadPixels should not zero its dest buffer when reading outside the framebuffer boundary

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(2 files)

At some point, we made the assumption that an arraybuffer passed to readpixels will always be completely consumed. Instead, sometimes it's desired to read pixel data into an over-large slice of an arraybuffer. Thus, we shouldn't ever zero out the buffer, but rather only zero the range that the pixel data will fill.
Attached file testcase
Testcase will raise exceptions if we're zeroing too much.
Attachment #756288 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/168ac1fee3c8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: