Closed
Bug 877934
Opened 11 years ago
Closed 11 years ago
ReadPixels should not zero its dest buffer when reading outside the framebuffer boundary
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(2 files)
1.54 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
1.79 KB,
text/html
|
Details |
At some point, we made the assumption that an arraybuffer passed to readpixels will always be completely consumed. Instead, sometimes it's desired to read pixel data into an over-large slice of an arraybuffer. Thus, we shouldn't ever zero out the buffer, but rather only zero the range that the pixel data will fill.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #756288 -
Flags: review?(bjacob)
Assignee | ||
Comment 2•11 years ago
|
||
Testcase will raise exceptions if we're zeroing too much.
Updated•11 years ago
|
Attachment #756288 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/168ac1fee3c8
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/168ac1fee3c8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•