877982 - JAWS misses textarea in Firefox 23

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

JAWS misses textarea because we started to expose textarea children in Firefox 23 because of bug 865997. It's not a problem on trunk because it was fixed by bug 873358. We can't backport bug 873358 because it regressed by bug 875794 which will be fixed by set of related patches. Thus we need to back out partially bug 865997 that caused this problem.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 756427 [details] [diff] [review]
patch

patches to that function are almost unreadable, maybe we should convert role checks to simple if and return or if we really think compilers can't figure that out array and loop.

complaining asside this seems fine

Comment 3

[alexander :surkov (:asurkov)]

this patch goes into aurora only, thus maybe it doesn't important

Comment 4

[alexander :surkov (:asurkov)]

can we get a try build against aurora?

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #3)
> this patch goes into aurora only, thus maybe it doesn't important

sure, but I don't see why that should mean we shouldn't clean this code up some day.

(In reply to alexander :surkov from comment #4)
> can we get a try build against aurora?

I don't see a reason you can't push aurora with this patch to try

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #5)
> (In reply to alexander :surkov from comment #3)
> > this patch goes into aurora only, thus maybe it doesn't important
> 
> sure, but I don't see why that should mean we shouldn't clean this code up
> some day.

I thought you concerned this patch only.

> (In reply to alexander :surkov from comment #4)
> > can we get a try build against aurora?
> 
> I don't see a reason you can't push aurora with this patch to try

do I need aurora repo on my machine for that?

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #6)
> (In reply to Trevor Saunders (:tbsaunde) from comment #5)
> > (In reply to alexander :surkov from comment #3)
> > > this patch goes into aurora only, thus maybe it doesn't important
> > 
> > sure, but I don't see why that should mean we shouldn't clean this code up
> > some day.
> 
> I thought you concerned this patch only.

not really

> > (In reply to alexander :surkov from comment #4)
> > > can we get a try build against aurora?
> > 
> > I don't see a reason you can't push aurora with this patch to try
> 
> do I need aurora repo on my machine for that?

I can't see how you'd push commits you don't have locally

Comment 8

[alexander :surkov (:asurkov)]

can you do that for me?

Comment 9

[Marco Zehe (:MarcoZ)]

(In reply to alexander :surkov from comment #8)
> can you do that for me?

I can, *after* the bug has received approval for it. I will request it.

Comment 10

[alexander :surkov (:asurkov)]

I meant a try build against aurora branch.

Comment 11

[Marco Zehe (:MarcoZ)]

Comment on attachment 756427 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 865997
User impact if declined: Users of the popular screen reader JAWS would no longer be able to access and focus any text area form elements.
Testing completed (on m-c, etc.): No, this is an aurora-specific partial backout of bug 865997, see comment #0 for a more detailed description of why this is needed.
Risk to taking this patch (and alternatives if risky): None.
String or IDL/UUID changes made by this patch: None.

Comment 12

[Marco Zehe (:MarcoZ)]

Pushed to Aurora and marking fixed since this is an aurora (Firefox 23) specific bug.
https://hg.mozilla.org/releases/mozilla-aurora/rev/2e6aaff6439a