878000 - ProxyAutoconfig should set a stack quotum when creating a JS runtime

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Eddy Bruel [:ejpbruel]]

ProxyAutoConfig creates a new JS runtime. Whenever we do this, we also need to set a stack quotum. Not doing this could cause JS_CHECK_RECURSION to report false positives.

This is blocking us from landing bug 637572.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Single line fix

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 756453 [details] [diff] [review]
Single line fix

Review of attachment 756453 [details] [diff] [review]:
-----------------------------------------------------------------

I may be overstepping my bounds a little bit by r+ing this, but I'm going to do it anyways.

::: netwerk/base/src/ProxyAutoConfig.cpp
@@ +528,5 @@
> +    /*
> +     * Not setting this will cause JS_CHECK_RECURSION to report false
> +     * positives
> +     */ 
> +    JS_SetNativeStackQuota(mRuntime, 128 * sizeof(size_t) * 1024); 

More extra whitespace at EOL.

Comment 3

[Patrick McManus [:mcmanus]]

kyle's review is fine by me. (and appreciated too!)

Comment 4

[Eddy Bruel [:ejpbruel]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/1180fa46316f

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1180fa46316f