878018 - Default gtest inclusion breaks VC 2012 builds on Windows

Status: RESOLVED DUPLICATE of bug 871801

(Firefox Build System :: General, defect)

Description

[Jim Mathies [:jimm]]

Will include a dump of build errors.

Comment 1

[Jim Mathies [:jimm]]

test-all.cc
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(124) : error C2977: 'std::tuple' : too many template argumen
ts
        C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\INCLUDE\utility(73) : see declaration of 'std::tuple'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(124) : error C3203: 'tuple' : unspecialized class template c
an't be used as a template argument for template parameter 'Tuple', expected a real type
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(124) : error C2955: 'std::tuple' : use of class template req
uires template argument list
        C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\INCLUDE\utility(73) : see declaration of 'std::tuple'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(127) : error C2977: 'testing::internal::MatcherTuple' : too
many template arguments
        t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(124) : see declaration of 'testing::internal::Matche
rTuple'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(136) : error C2977: 'testing::internal::MatcherTuple' : too
many template arguments
        t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(132) : see declaration of 'testing::internal::Matche
rTuple'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2065: 'A1' : undeclared identifier
        t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(152) : see reference to class template instantiation
 'testing::internal::Function<F>' being compiled
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2923: 'testing::Matcher' : 'A1' is not a valid
 template type argument for parameter 'T'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2065: 'A2' : undeclared identifier
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2923: 'testing::Matcher' : 'A2' is not a valid
 template type argument for parameter 'T'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2065: 'A3' : undeclared identifier
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2923: 'testing::Matcher' : 'A3' is not a valid
 template type argument for parameter 'T'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2065: 'A4' : undeclared identifier
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(133) : error C2923: 'testing::Matcher' : 'A4' is not a valid
 template type argument for parameter 'T'
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(134) : error C2065: 'A5' : undeclared identifier
t:\Mozilla\mc\testing\gtest\gmock\include\gmock/internal/gmock-generated-internal-utils.h(134) : error C2923: 'testing::Matcher' : 'A5' is not a valid

...

lots more below this.

Comment 2

[Jim Mathies [:jimm]]

Related - bug 773454, we had a similar problem with WebRTC tests.

Comment 3

[(not currently active) Ted Mielczarek]

This just needs the same -D_VARIADIC_MAX=10 fix.

Comment 4

[Ethan Hugg [:ehugg]]

Please try the patch from bug 871801.  We will be pushing it shortly.