The accented key will all be shown as uppercase

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rudyl, Assigned: rudyl)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(b2g18 unaffected, b2g18-v1.0.0 unaffected, b2g18-v1.0.1 unaffected)

Details

Attachments

(1 attachment)

STR
===

1. Activate the Gaia keyboard
2. long press on some keys with alternative keys (accented letters)
   like "s"

Actual: the accented keys will all be shown uppercase not master what caps mode is on
Expected: the accented keys will be shown correctly.

--
This is a regression from 56c24eac2ee5f749126a07606ab9ec8e8d3a4638/Bug 860318.
Created attachment 756511 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10132

Pointer to Github pull-request
Comment on attachment 756511 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10132

This is a one-line patch to fix the issue that we wrongly applied text-transform:uppercase to all the keys, so the accented keys would also be affected.

Hi Tim,
Could you please review this?
Thank you.
Attachment #756511 - Flags: review?(timdream)
Comment on attachment 756511 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10132

Please make sure our text-transform usage doesn't break on special cases as there are more than one type of upper/lower case mapping for Latin script in the world. Thanks!

https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform#Browser_compatibility
http://en.wikipedia.org/wiki/Letter_case#Special_cases
Attachment #756511 - Flags: review?(timdream) → review+
Will do.
(That seems kind-of complicated.)

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/d2896a8c668081f33c1890c2a35072211fa42fa2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g18: --- → unaffected
status-b2g18-v1.0.0: --- → unaffected
status-b2g18-v1.0.1: --- → unaffected
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.