Closed Bug 878042 Opened 7 years ago Closed 7 years ago

[MMS] Apply this image place holders and specs for different cases

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

x86
macOS
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: vicky, Assigned: kaze)

References

Details

(Whiteboard: [TD-47378])

Attachments

(6 files, 7 obsolete files)

The thumbnails set has been updated in order to well cover all common and edge cases. Please follow this specs and use this assets:

Use of Thumbnails

- GENERIC for other file formats
- VIDEO Files
- MUSIC files
- IMAGE with no preview
- IMAGES WITH PREVIEW (RULES): Images will be used with the real preview and aspect ratio, the image size will be determined by the larger side being a maximum of 12rem (X max size in landscape and Y max size in portrait). When an image's shorter size turns to be less than 4 rem, that side will be filled with a background color to complete 8 rem both for landscape and portrait

Also there has been designed:
ICON to overlay files that cannot be opened
ICON to overlay files that are broken
Blocks: 872514
blocking-b2g: --- → leo?
Assignee: nobody → pla
Attached file Exported image assets (obsolete) —
Attached image Spec for blue frame (obsolete) —
Please take a look at all 4 attachments.  Particularly the 3 specs.

For the case of very long images with aspect ratio greater than 1:5:1, whether landscape or portrait, there are 3 options.

Whichever option is chosen, it should be the same one for both landscape and portrait.
blocking-b2g: leo? → leo+
Corrected some typos in the spec.
Attachment #756630 - Attachment is obsolete: true
Box.com link to latest version of spec:
https://mozilla.box.com/s/miprycvuqmap0w0w17fy
Attachment #756629 - Attachment is obsolete: true
Box.com link to latest version of spec:
https://mozilla.box.com/s/miprycvuqmap0w0w17fy
Attachment #757426 - Attachment is obsolete: true
Attached image Spec for blue frame
Box.com link to latest version of spec:
https://mozilla.box.com/s/miprycvuqmap0w0w17fy
Attachment #756631 - Attachment is obsolete: true
Changed images to make examples clearer.
Attachment #757440 - Attachment is obsolete: true
Changed images to make examples clearer.
Attachment #757441 - Attachment is obsolete: true
Taking the Gaia part.
Assignee: pla → kaze
Attachment #759880 - Flags: feedback?(felash)
Blocks: 876467
Comment on attachment 759880 [details]
link to pull request

Flipping reviewer to julien - I'm @ a conference this week
Attachment #759880 - Flags: review?(gnarf37) → review?(felash)
discussed on IRC and on github: some work is still needed, we'll try to factorize the 2 functions where we resize images. The main difference is when we calculate the ratio: one function needs to calculate the ratio so that the resulting image is about 300 kB, the other unction needs to calculate the ratio so that it fits a certain size. The remaining code is the same.

Apart from that, this is mostly nits.
Comment on attachment 759880 [details]
link to pull request

r=me with the nits

please run all the tests + linter + test on the device before merging please :)
Attachment #759880 - Flags: review?(felash) → review+
The unit tests have been trickier than expected, but it’s done:
https://github.com/mozilla-b2g/gaia/commit/bad6ca6977451321f7528e02f320308b0a6fba53
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted bad6ca6977451321f7528e02f320308b0a6fba53 to:
v1-train: 5108e3525fb41dfd58620cee21ceb7c1ab5b6f8f
1.1hd: 5108e3525fb41dfd58620cee21ceb7c1ab5b6f8f
Update to image assets.  @2x set added.

For the @1x size, fixed the 3 overlay icons' canvas size.  They were mistakenly saved out at 82x80, when they should have been 82x82.  This is now corrected.
Attachment #756627 - Attachment is obsolete: true
Attachment #764173 - Flags: review?(vpg)
Hi Peter, I’m afraid we landed and uplifted this bug last week. Could you open a new bug please?

(In reply to Peter La from comment #21)
> For the @1x size, fixed the 3 overlay icons' canvas size.  They were
> mistakenly saved out at 82x80, when they should have been 82x82.  This is
> now corrected.

Note that I cropped all attachment icons to 80x80 pixels: following comment 10, I used 80x80 px icons for the inner of the <iframe>, and applied a 1px blue border with rounded corners to the <iframe> itself.
Flags: needinfo?(pla)
Priority: -- → P1
Whiteboard: [TD-47378]
Target Milestone: --- → 1.1 QE3 (24jun)
Hi Kaze,

Thanks for pointing that out.  I created a new bug here:
https://bugzilla.mozilla.org/show_bug.cgi?id=884975

Let me know if there are any problems with it - I wasn't sure if this is for the same target and what the priority should be so I set them to be the same for now.
Flags: needinfo?(pla)
Calculations for the 2x images are a bit wrong... Can you take a second look Peter? Thanks!
Flags: needinfo?(pla)
Victoria, please see bug 884975 for any issue regarding 2x images. Thanks!
Attachment #764173 - Flags: review?(vpg) → review?
Clearing my needsinfo as I spoke to Vicky about this via email, and my input is no longer needed.
Flags: needinfo?(pla)
You need to log in before you can comment on or make changes to this bug.