40MB AWSY regression on May 31

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Timvde, Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
It looks like bug 867770 introduced a regression of about 40MB on AWSY after TP5, before closing the tabs. The misc graph shows almost all of the lost memory in heap-unclassified.
Whiteboard: [MemShrink]
Blocks: 867770
(Assignee)

Updated

4 years ago
Assignee: nobody → joe
(Assignee)

Updated

4 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

4 years ago
Created attachment 756783 [details] [diff] [review]
don't TryOptimizeToImageLayer() if the optimization is disabled

This should fix the bug, though I still need to verify that on AWSY. We were always optimizing background images to image layers, which we know will cause more memory use—which is the reason for the pref I added in the first place, actually.

https://tbpl.mozilla.org/?tree=Try&rev=143458b5a910
Attachment #756783 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

4 years ago
BTW: Is there a bug on Image* (ImageLayer, ImageContainer, Image) not reporting their sizes?
Hey John, could you annotate AWSY with the bug number of this regression?  Or the regressor, I guess.  Thanks.
Flags: needinfo?(jschoenick)
Thanks for quickly investigating and patching this regression, Joe!
Attachment #756783 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff8cbefdf10

I'm running this on AWSY, but it is unlikely to make things *worse* so I've pushed it too.
(Assignee)

Comment 6

4 years ago
This seems to have fixed the regression.
Annotated on AWSY:
https://github.com/Nephyrin/MozAreWeSlimYet/commit/2c282f6
Flags: needinfo?(jschoenick)
https://hg.mozilla.org/mozilla-central/rev/2ff8cbefdf10
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.