878062 - 40MB AWSY regression on May 31

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Timvde]

It looks like bug 867770 introduced a regression of about 40MB on AWSY after TP5, before closing the tabs. The misc graph shows almost all of the lost memory in heap-unclassified.

Comment 1

[Joe Drew (not getting mail)]

Attachment: don't TryOptimizeToImageLayer() if the optimization is disabled

This should fix the bug, though I still need to verify that on AWSY. We were always optimizing background images to image layers, which we know will cause more memory use—which is the reason for the pref I added in the first place, actually.

https://tbpl.mozilla.org/?tree=Try&rev=143458b5a910

Comment 2

[Joe Drew (not getting mail)]

BTW: Is there a bug on Image* (ImageLayer, ImageContainer, Image) not reporting their sizes?

Comment 3

[Andrew McCreight [:mccr8]]

Hey John, could you annotate AWSY with the bug number of this regression?  Or the regressor, I guess.  Thanks.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for quickly investigating and patching this regression, Joe!

Comment 5

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff8cbefdf10

I'm running this on AWSY, but it is unlikely to make things *worse* so I've pushed it too.

Comment 6

[Joe Drew (not getting mail)]

This seems to have fixed the regression.

Comment 7

[John Schoenick [:johns]]

Annotated on AWSY:
https://github.com/Nephyrin/MozAreWeSlimYet/commit/2c282f6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ff8cbefdf10