878131 - isPrivate() should return true if the new global private browsing mode is enabled

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

There is a new global private browsing mode that was implemented quietly that I only learned about yesterday.

This one requires a restart to enable/disable so it's even more strict than the previous global private browsing service was.

Basically isPrivate() should always return true now if this is enabled..

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Btw this global pb mode is already on release, go to preferences -> privacy -> history -> custom and you will see it.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

A think at last triage meeting we decided to take this discussion to a broader audience, primarily to understand UX perspective on this subject.

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I'll email people and get some feedback for us on what the intention here was.

Comment 4

[(no longer active)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #0)
> There is a new global private browsing mode that was implemented quietly
> that I only learned about yesterday.

This is a very misleading statement.  This was not implemented quietly, and has been supported since Firefox 3.5.

> This one requires a restart to enable/disable so it's even more strict than
> the previous global private browsing service was.
> 
> Basically isPrivate() should always return true now if this is enabled..

Yes, that's correct.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #0)
> > There is a new global private browsing mode that was implemented quietly
> > that I only learned about yesterday.
> 
> This is a very misleading statement.  This was not implemented quietly, and
> has been supported since Firefox 3.5.

Sorry I meant re-implemented.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #0)
> > Basically isPrivate() should always return true now if this is enabled..
> 
> Yes, that's correct.

So isPrivate should return the value of browser.privatebrowsing.autostart by default?  or is there something better that I am missing?

Using browser.privatebrowsing.autostart seems hairy since it can be changed without a restart and from what I can tell affects new windows.

Comment 7

[Josh Matthews [:jdm]]

Use PrivateBrowsingUtils.permanentPrivateBrowsing instead. Regardless, modifying the pref outside of startup is unsupported.

Comment 8

[(no longer active)]

(In reply to comment #7)
> Use PrivateBrowsingUtils.permanentPrivateBrowsing instead. Regardless,
> modifying the pref outside of startup is unsupported.

isPrivate is read-only, right?

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #8)
> (In reply to comment #7)
> > Use PrivateBrowsingUtils.permanentPrivateBrowsing instead. Regardless,
> > modifying the pref outside of startup is unsupported.
> 
> isPrivate is read-only, right?

Our require('sdk/private-browsing').isPrivate(thing?) method is read only yes.

Everything else exported from require('sdk/private-browsing') is deprecated and only works with the global pb service.

Comment 10

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1042/files

Pointer to Github pull-request

Comment 11

[(no longer active)]

Comment on attachment 764825 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1042/files

Looks good.  I think you can drop the "!!" as I mentioned on github.

Comment 12

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 764825 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1042/files

Thanks

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/90762ccf69007431ceeaaae609014f661f8ebd38
Bug 878131: isPrivate() now always returns true if the new global pb service is enabled

https://github.com/mozilla/addon-sdk/commit/5acefbc7605e6bbe5e1fb084c0aacf110c68793a
Merge pull request #1042 from erikvold/878131

Bug 878131: isPrivate() now always returns true if the new global pb service is enabled r=@Gozala

Comment 14

[[github robot]]

Commits pushed to australis at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/90762ccf69007431ceeaaae609014f661f8ebd38
Bug 878131: isPrivate() now always returns true if the new global pb service is enabled

https://github.com/mozilla/addon-sdk/commit/5acefbc7605e6bbe5e1fb084c0aacf110c68793a
Merge pull request #1042 from erikvold/878131

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Erik?