Closed
Bug 878205
Opened 12 years ago
Closed 12 years ago
gbdate.pl is unused and can be removed
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
We have a utility perl-script layout/build/gbdate.pl, which when run, just prints out (to the terminal):
> #define PRODUCT_VERSION "20130531"
(that's the current date)
We don't use this #define anywhere (though some chromium & NSS code happens to use the same name):
http://mxr.mozilla.org/mozilla-central/search?string=PRODUCT_VERSION&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Plus, it hasn't been touched (aside from the license block) in over 10 years:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/layout/build/gbdate.pl&rev=HEAD&mark=1.5
http://hg.mozilla.org/mozilla-central/filelog/4c7a395fadcc/layout/build/gbdate.pl
I think we can get rid of it.
| Assignee | ||
Comment 1•12 years ago
|
||
Forgot to mention -- no other file in the tree has any mention of this file:
http://mxr.mozilla.org/mozilla-central/search?string=gbdate.pl
so nothing invokes it, and we don't have any comments that refer to it.
| Assignee | ||
Comment 2•12 years ago
|
||
Updated•12 years ago
|
Attachment #756746 -
Flags: review?(matspal) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Flags: in-testsuite-
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•