Open
Bug 878325
Opened 9 years ago
Updated 3 years ago
XUL template builder needs to do a better job propagating exceptions
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: bholley, Unassigned)
References
Details
Attachments
(3 files)
1.94 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
2.75 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
3.59 KB,
patch
|
Details | Diff | Splinter Review |
I'm doing some work that causes WrapNative to throw more often, in cases where it should. But it's uncovered a few consumers that don't do a good job of propagating exceptions all the way up. This stuff is one of them.
Reporter | ||
Updated•9 years ago
|
Summary: XUL template build needs to do a better job propagating exceptions → XUL template builder needs to do a better job propagating exceptions
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #756837 -
Flags: review?(bzbarsky)
Reporter | ||
Comment 2•9 years ago
|
||
Attachment #756838 -
Flags: review?(bzbarsky)
![]() |
||
Comment 3•9 years ago
|
||
Comment on attachment 756837 [details] [diff] [review] Part 1 - Propagate exceptions out of CreateTemplateBuilder and LoadDataSources. v1 r=me
Attachment #756837 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 4•9 years ago
|
||
Comment on attachment 756838 [details] [diff] [review] Part 2 - Propagate exceptions out of ResolveForwardReferences. v1 Let's hope this doesn't break some weird edge case....
Attachment #756838 -
Flags: review?(bzbarsky) → review+
Reporter | ||
Comment 5•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a39e18e5a7 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/803586f0a297
Comment 6•9 years ago
|
||
Backed out for mochitest-other orange. https://hg.mozilla.org/integration/mozilla-inbound/rev/0a6f4bdb34bf https://tbpl.mozilla.org/php/getParsedLog.php?id=23726714&tree=Mozilla-Inbound
Reporter | ||
Comment 7•9 years ago
|
||
Hm, so this busted two tests: content/xul/templates/tests/chrome/test_tmpl_invalidqp.xul content/xul/templates/tests/chrome/test_tmpl_storage_baddatasource.xul It looks like these things are both designed to throw, but are somehow getting tripped up where they weren't before. I really don't know enough about this code to debug it though. Enn, can you apply the patches and have a look?
Flags: needinfo?(enndeakin)
Comment 8•9 years ago
|
||
The code here has its own logging which one can enable, The two specific errors being tested for here should really just silently fail when the logging is disabled.
Flags: needinfo?(enndeakin)
Comment 9•9 years ago
|
||
However, since opening the test seems to cause the test's page to never stop loading, there is some other bug here as well. I assume an error result from XULDocument::ResolveForwardReferences isn't causing some cleanup to occur properly.
Reporter | ||
Comment 10•9 years ago
|
||
If you squelch exceptions, you need to call JS_ClearPendingException.
Reporter | ||
Updated•7 years ago
|
Assignee: bobbyholley → nobody
Assignee | ||
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•