878415 - java.lang.NullPointerException: at org.mozilla.gecko.ActivityHandlerHelper$6.gotIntent(ActivityHandlerHelper.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 24.0a1/20130531: bp-26edd23c-6939-4b6b-a857-297e12130531.

java.lang.NullPointerException
	at org.mozilla.gecko.ActivityHandlerHelper$6.gotIntent(ActivityHandlerHelper.java:319)
	at org.mozilla.gecko.ActivityHandlerHelper$3.onPromptFinished(ActivityHandlerHelper.java:212)
	at org.mozilla.gecko.Prompt.finishDialog(Prompt.java:473)
	at org.mozilla.gecko.Prompt.onCancel(Prompt.java:453)
	at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1259)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4561)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.ActivityHandlerHelper%246.gotIntent%28ActivityHandlerHelper.java%29

Comment 1

[Scoobidiver (away)]

Hit by other users. The regression range might be (discontinuous across builds):
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f66d956d188e&tochange=3c6f2394995d

A comment says: "If I choose file and touch back key, Nightly have crashed".

So it's likely a regression from bug 874689.

Comment 2

[Catalin Suciu [:csuciu]]

I can reproduce the crash on the latest Nightly build.

Steps: 
1. Go to about:memory and press Load
2. Hit back to dismiss the "Choose File" screen

Actual: Nightly crashes

This issue was introduced in Nightly 2013-05-31

Comment 3

[Scoobidiver (away)]

It's #7 top crasher in 24.0a1.

Comment 4

[Aaron Train [:aaronmt]]

I hit this using http://mysecondwebrtc.appspot.com/ hitting the input button

Comment 5

[Aaron Train [:aaronmt]]

(hitting the Choose Button input, and then hitting the back button)

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch

Forgot the return statement here.

I added another null check as well and figured I would leave it in (we still show the file picker, so you could potentially show one and not care about the result?). I also reordered some string comparisons to ensure the left hand side isn't null.

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 760646 [details] [diff] [review]
Patch

Review of attachment 760646 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. The null checks don't seem necessary atm since the handler passed in is never null. Perhaps add a method comment for showFilePickerIntentAsync and getFilePickerAsync explicitly saying null handler is ok when you don't care about the activity result.

Comment 8

[Wesley Johnston (:wesj)]

Added some comments and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28d0bf47817c

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/28d0bf47817c

Comment 10

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 24.0a1 2013-06-18