878472 - Let local debugger clients find the DebuggerServerConnection

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

This shouldn't be too easy or common, but there are a few cases where we want to get to the server side of a debugger connection from the client.  There's at least one test that tries to do that, we're going to need it while we convert the inspector, and Firebug does it.

This puts a reference to the DebuggerServerConnection on the client's local transport object.  I also updated the test that pokes through _connections.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 757019 [details] [diff] [review]
v1

Review of attachment 757019 [details] [diff] [review]:
-----------------------------------------------------------------

How about a big fat warning in a comment somewhere that if you are using the server connection from the client, you are probably doing it wrong?

Comment 2

[Dave Camp (:dcamp)]

Comment on attachment 757019 [details] [diff] [review]
v1

Yeah, I can add that.

Comment 3

[Dave Camp (:dcamp)]

Adding the following comment:

    // I'm putting this here because I trust you.
    //
    // There are times, when using a local connection, when you're going
    // to be tempted to just get direct access to the server.  Resist that
    // temptation!  If you succumb to that temptation, you will make the
    // fine developers that work on Fennec and Firefox OS sad.  They're
    // professionals, they'll try to act like they understand, but deep
    // down you'll know that you hurt them.
    //
    // This reference allows you to give in to that temptation.  There are
    // times this makes sense: tests, for example, and while porting a
    // previously local-only codebase to the remote protocol.
    //
    // But every time you use this, you will feel the shame of having
    // used a property that starts with a '_'.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Love it!

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/94cae09bda18

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94cae09bda18