Aero tabbar shadow purple instead of gray/white

RESOLVED FIXED in Thunderbird 25.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: M4he, Assigned: Paenglab)

Tracking

17 Branch
Thunderbird 25.0
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gs], URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.94 Safari/537.36

Steps to reproduce:

I'm running Thunderbird 17 on Windows 7 Professional x64 using Thunderbird's default theme.


Actual results:

There's a purple glow/shadow in the background of the tabbar region when Aero is enabled. Screenshot: http://i.imgur.com/3lTli4t.jpg

This texture was introduced with: https://bugzilla.mozilla.org/show_bug.cgi?id=793265 and is located at "mail/themes/qute/mail/icons/tabbar-background.png" within the source files. The color used at the center bottom pixel of this PNG is #9191BC which has a noticeable purple tint.
The purple color is kinda irritating and looks totally out of place.


Expected results:

The glow/shadow texture should have a neutral color, preferably gray or white instead of purple.

Comment 1

5 years ago
Confirmed, the semi-transparent tabbar-background.png makes an assumption on the color scheme of the underlying desktop theme which may result in irritating color combinations. It should be neutral (i.e., color saturation should be zero).
Blocks: 793265
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

5 years ago
Whiteboard: [gs]
(Assignee)

Comment 2

5 years ago
Created attachment 757104 [details] [diff] [review]
patch

This patch uses the approach from Firefox UX-builds (Australis).

Mike, sorry to fill your reviewer-queue but you are the specialist for this with your experience on FX-Australis.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #757104 - Flags: ui-review?(mconley)
Attachment #757104 - Flags: review?(mconley)

Comment 3

5 years ago
Comment on attachment 757104 [details] [diff] [review]
patch

>+  #tabs-toolbar:not(:-moz-lwtheme)::before {
>+    box-shadow: 0 0 30px 30px rgb(174, 189, 204);

I'm not exactly sure what this does, but wouldn't it again introduce a blueish shadow that may or may not go well with the underlying desktop theme?
(Assignee)

Comment 4

5 years ago
Yes, but this the color whis is approved by UX team. Let's decide Mike if we should use this or a real gray. He is in close contact with the UX team and knows what is planned on FX side.

Comment 5

5 years ago
Ok, so the patch doesn't really address the issue for which the reporter opened this bug but merely changes the method how to achieve the effect.

Let's get some more opinions on this from the relevant people.
Flags: needinfo?(bwinton)
Flags: needinfo?(bugs)
I'm happy to let Mike decide this.
Flags: needinfo?(bwinton)
Flags: needinfo?(mconley)
(In reply to Richard Marti [:Paenglab] from comment #2)
> Mike, sorry to fill your reviewer-queue but you are the specialist for this
> with your experience on FX-Australis.

I'll do my best. :)
Flags: needinfo?(mconley)
As usual, I've been having difficulty getting TB to build on Windows. I just got it going again, so I'll be able to review this soon.
(In reply to Richard Marti [:Paenglab] from comment #4)
> Yes, but this the color whis is approved by UX team.

Just curious - where did you find this colour? Was it used by Firefox somewhere (I can't find it), or is it part of a spec?
Flags: needinfo?(richard.marti)
(Assignee)

Comment 10

4 years ago
This comes from http://hg.mozilla.org/projects/ux/file/59e0b786a639/browser/themes/windows/browser-aero.css#l232 with changeset http://hg.mozilla.org/projects/ux/rev/4d301b6c8d27 and bug 738491.
Flags: needinfo?(richard.marti)
Comment on attachment 757104 [details] [diff] [review]
patch

Review of attachment 757104 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, ok. You have to remember that I didn't work on the Windows implementation of the curvy tabs. :)

But this looks good. Thanks Richard!
Attachment #757104 - Flags: ui-review?(mconley)
Attachment #757104 - Flags: ui-review+
Attachment #757104 - Flags: review?(mconley)
Attachment #757104 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/711a53006da4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0

Updated

4 years ago
Flags: needinfo?(bugs)
You need to log in before you can comment on or make changes to this bug.