878505 - OdinMonkey: reading from float view gives doublish but writing requires double?

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

function g(stdlib, foreign, heap)
{
  "use asm"
  var Float32ArrayView = new stdlib.Float32Array(heap)
  function f()
  {
    Float32ArrayView[0] = Float32ArrayView[1];
  }
  return f;
}

/Users/jruderman/Desktop/asmjs/e.js:7:0 warning: asm.js type error: doublish is not double

(Is this an intentional deviation from the spec?)

Comment 1

[Jesse Ruderman]

In contrast, intish works fine:

function g(stdlib, foreign, heap)
{
  "use asm"
  var Int32ArrayView = new stdlib.Int32Array(heap)
  function f()
  {
    Int32ArrayView[0] = Int32ArrayView[1];
  }
  return f;
}

Comment 2

[cscott]

My reading of the spec is that both intish heaps and doublish heaps should work, and both of these examples validate in http://turtlescript.github.cscott.net/docco/asm-llvm.html

(Maybe I should make asm-llvm an online checker?)

Comment 3

[Luke Wagner [:luke]]

Yeah, we talked about it on irc and I think this is just a simple bug in Odin.

Comment 4

[Luke Wagner [:luke]]

Attachment: fix and test

Comment 5

[Jesse Ruderman]

>             return f.failf(lhs, "%s is not a subtype of intish", rhsType.toChars());

vs

>+            return f.failf(lhs, "%s is not doublish", rhsType.toChars());

seems like a minor inconsistency.

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 760095 [details] [diff] [review]
fix and test

Review of attachment 760095 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! As Jesse pointed out, it would be also nice that the messages have the same form.
And still for the purposes of consistency, should we change the enum element |ArrayStore_Double| to |ArrayStore_Doublish|?

Comment 7

[Luke Wagner [:luke]]

Mmm, by sense of style seems weak at 2am.  Thanks guys

Comment 8

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1eff67ffe6b9

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1eff67ffe6b9