878568 - Firefox for Android: Spoken (TalkBack) strings always taken from English resource even when UI is localized

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Marco Zehe (:MarcoZ)]

Reported for Dutch, but I also reproduced in German: For a number of 24 nightly builds, everything that is in the dom/localization/accessibility/accessfu.properties file is always taken from the English resource, not the localized one. There were no major updates to that file in months, and localizations used to work fine in nightly builds. The UI, like the menu and Android native button labels, are localized just fine, only the stuff for web content like the roles and states, are no longer being localized.

Comment 1

[Axel Hecht [:Pike]]

We have the localizations for at least a few table-related terms on central, http://mxr.mozilla.org/l10n-central/search?string=table&find=AccessFu.properties&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central.

Do those work?

Comment 2

[Francesco Lodolo [:flod]]

I've just downloaded the multi apk, unzipped it, and then unzipped omni.ja.

Inside the chrome folder the only AccessFu.properties that I found is stored inside en-US (en-US/global).

Comment 3

[Francesco Lodolo [:flod]]

Could it be related to bug 792077?
https://hg.mozilla.org/mozilla-central/rev/2aed3055baf6

Comment 4

[Axel Hecht [:Pike]]

Yes, this is a regression from bug 792077.

Comment 5

[Axel Hecht [:Pike]]

Attachment: add AccessFu.properties to localized toolkit set

Marco, trying you for review. The real review item here is: do we just need accessfu.properties for a11y on android, or are there more files?

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 757322 [details] [diff] [review]
add AccessFu.properties to localized toolkit set

>+  locale/@AB_CD@/browser/overrides/AccessFu.propertie          (%chrome/accessibility/AccessFu.properties)

If you change .propertie to .properties, then r=me. This is the only file needed for Android, as can be seen in m-c in the foler under DOM. The Win, Unix etc. folders are not needed for Android.

Comment 7

[Axel Hecht [:Pike]]

Moving over to Android, as it's better suited over there.

Also, landed on inbound, https://hg.mozilla.org/integration/mozilla-inbound/rev/a60ac0888ab1

Comment 8

[Axel Hecht [:Pike]]

Requesting tracking 23, as that's where the regression happened.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a60ac0888ab1

Comment 10

[Axel Hecht [:Pike]]

The nightly we're building right now will have this change, it'd be great if you can test that build to verify the fix. That should be live in a few hours from now.

Comment 11

[Marco Zehe (:MarcoZ)]

I can verify that this works again in the multi-lingual 24.0a1 (2013-06-05) nightly build on a German Android device. So this should be requested to go into Aurora, too, so the regression can be fixed there.

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 757322 [details] [diff] [review]
add AccessFu.properties to localized toolkit set

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 792077
User impact if declined: No localized a11y messages on Android
Testing completed (on m-c, etc.): Verified on nightly
Risk to taking this patch (and alternatives if risky): Only adding an existing file to the build
String or IDL/UUID changes made by this patch: none, the packaged strings already exist.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e3ec3f1deecd