878614 - Handle subdocument loads/unloads in the inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

Comment 1

[Joe Walker [:jwalker]]

Comment on attachment 757174 [details] [diff] [review]
v1

Review of attachment 757174 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +561,5 @@
>    }
>  }
> +const { Unknown } = require("sdk/platform/xpcom");
> +const { Class } = require("sdk/core/heritage")
> +var ProgressListener = Class({

Could you document the point of ProgressListener?

I guess something like:

/**
 * ProgressListener makes it easier to be a notified of
 * the start and finish of the loading of async
 * requests.
 * See nsIWebProgressListener for details
 * https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIWebProgressListener
 */

@@ +575,5 @@
> +  destroy: function() {
> +    this.webProgress.removeProgressListener(this);
> +  },
> +
> +  onStateChange: makeInfallible(function stateChange(progress, request, flag, status) {

What does makeInfallible do?

Comment 2

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/97ca769b1ed6

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/97ca769b1ed6