Closed
Bug 878672
Opened 11 years ago
Closed 11 years ago
Remove extra CRLF of result codes
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: echou, Assigned: ben.tian)
Details
(Whiteboard: [fixed-in-birch])
Attachments
(1 file)
|
1.34 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
According to section 4.33.1 General in HFP spec 1.5/1.6, "The format of an unsolicited result code from the AG to the HF shall be <cr><lf><result code><cr><lf>" Currently we add CRLF twice when forming reuslt codes 'RING' and 'CLIP', and it's incorrect. It needs to be revised even it could pass certification test. (So this shouldn't block Bluetooth certification) There is another bug mentioned this issue, see also bug 869468 comment 14.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → btian
|
Assignee | |
Comment 1•11 years ago
|
||
Eric, please help review this patch.
Attachment #757308 -
Flags: review?(echou)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 757308 [details] [diff] [review] Remove redundant CRLF of RING and CLIP Review of attachment 757308 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #757308 -
Flags: review?(echou) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
TryServer link: https://tbpl.mozilla.org/?tree=Try&rev=30dacfcc8e04
|
|
Reporter | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/81b59ee890a7
Whiteboard: [fixed-in-birch]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81b59ee890a7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•