Closed Bug 878672 Opened 8 years ago Closed 8 years ago

Remove extra CRLF of result codes

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: echou, Assigned: ben.tian)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file)

According to section 4.33.1 General in HFP spec 1.5/1.6, 

"The format of an unsolicited result code from the AG to the HF shall be
 <cr><lf><result code><cr><lf>"

Currently we add CRLF twice when forming reuslt codes 'RING' and 'CLIP', and it's incorrect. It needs to be revised even it could pass certification test. (So this shouldn't block Bluetooth certification)

There is another bug mentioned this issue, see also bug 869468 comment 14.
Assignee: nobody → btian
Eric, please help review this patch.
Attachment #757308 - Flags: review?(echou)
Comment on attachment 757308 [details] [diff] [review]
Remove redundant CRLF of RING and CLIP

Review of attachment 757308 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #757308 - Flags: review?(echou) → review+
https://hg.mozilla.org/mozilla-central/rev/81b59ee890a7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.