878700 - [Buri][Shira-49396]Untranslated text in 'Enter PIN' screen.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

SW160
 AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.121
 Firefox os  v1.0.1
 Mozilla build ID:20130527070203
 
 Created an attachment (id=418995)
 snapshot
 
 DEFECT DESCRIPTION:
 
  Untranslated text in 'Enter PIN' screen.
 
  REPRODUCING PROCEDURES:
 
 Power on with SIM card and PIN opened,system lanugae is
 English->access 'Enter PIN' screen->input correct PIN->restart for 1 or 2
 times->set system language as Polish/German->turn on airplane mode->turn off
 airplane->access 'Enter PIN' screen->display "3 tries left" in English==>KO
 
  EXPECTED BEHAVIOUR:
  ==>Should display in Polish/German.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:SW12C+DT
 
  USER IMPACT:Medium
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: snapshot

Clone from brother

Comment 3

[ying.tan]

BLOCK IOT

Comment 4

[Alex Keybl [:akeybl]]

Is this a recent regression? If not, we may need to explore options on your end to help with the translation since we're so close to shipping.

Comment 5

[Axel Hecht [:Pike]]

These strings appear to be available in Polish and German.

Given the path to them is cumbersome, I suspect this is a retranslation issue while switching locale.

Comment 6

[Staś Małolepszy :stas]

(In reply to Axel Hecht [:Pike] from comment #5)
> These strings appear to be available in Polish and German.
> 
> Given the path to them is cumbersome, I suspect this is a retranslation
> issue while switching locale.

https://github.com/mozilla-b2g/gaia/blob/v1.0.1/apps/system/index.html#L433 reads

    data-l10-id="inputCodeRetriesLeft"

instead of

    data-l10n-id="inputCodeRetriesLeft"

I haven't tested it yet.

Comment 7

[Staś Małolepszy :stas]

I can't reproduce this bug;   I keep seeing a string called pinAttempMsg2 instead of inputCodeRetriesLeft.  But my guess is that comment 6 is the root cause of the bug.

Comment 8

[buri.blff]

Follow the new STR, you may reproduce it 100%:
1. Set language as English, set SIM PIN enabled.
2. Restart your device.
3. When power on you will be required to enter SIM PIN, just input the correct pin.
4. Set language as Polish.
5. Enable "airplane mode".
6. Disable "airplane mode", then you will be required to enter SIM PIN again, this time it shows in English "3 tries left", not in Polish.

The change of comment 6 cannot fix it.

Comment 9

[Staś Małolepszy :stas]

Attachment: Screenshot: English and Polish seem to use a different string

I still can't repro.  I tried the newest build 20130605070208 and 20130527070203 from comment 0.  The attached screenshot is what I see in English and Polish.

Comment 10

[buri.blff]

(In reply to Staś Małolepszy :stas from comment #9)
> Created attachment 759005 [details]
> Screenshot: English and Polish seem to use a different string
> 
> I still can't repro.  I tried the newest build 20130605070208 and
> 20130527070203 from comment 0.  The attached screenshot is what I see in
> English and Polish.

Your screenshot is 2 tries left, that means you have input wrong pin once,
the problem is at 3 tries left screen, after input wrong pin, the display is ok, just like your screenshot.

Do you follow the STR in comment 8 ?

Comment 11

[Staś Małolepszy :stas]

(In reply to buri.blff from comment #10)

> Your screenshot is 2 tries left, that means you have input wrong pin once,
> the problem is at 3 tries left screen, after input wrong pin, the display is
> ok, just like your screenshot.

3 tries is the starting point, at which there is no error.  When I first enter a wrong pin, 2 tries are left.  How did you get to see "3 tries left"? :)

Comment 12

[buri.blff]

(In reply to Staś Małolepszy :stas from comment #11)
> (In reply to buri.blff from comment #10)
> 
> > Your screenshot is 2 tries left, that means you have input wrong pin once,
> > the problem is at 3 tries left screen, after input wrong pin, the display is
> > ok, just like your screenshot.
> 
> 3 tries is the starting point, at which there is no error.  When I first
> enter a wrong pin, 2 tries are left.  How did you get to see "3 tries left"?
> :)

Yes, 3 tries is the starting point, and problem is just here,
you can see attachment 757245 [details] if you follow the STR in comment 8

Comment 13

[Staś Małolepszy :stas]

(In reply to buri.blff from comment #12)
> Yes, 3 tries is the starting point, and problem is just here,
> you can see attachment 757245 [details] if you follow the STR in comment 8

I did follow the STR and all I could see is "Kod PIN karty SIM".  I didn't see "3 tries left" there.

Comment 14

[Michael Vines [:m1] [:evilmachines]]

:stas, you need to use the vendor build.

Comment 15

[Andrew Overholt [:overholt]]

Given comment #3 and comment #6 it seems like this is something that is blocking shipping for at least one partner.

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

this was not listed in the blocker list for shira release, i'd like to tef- it and set a tracking-b2g18+ flag instead

Comment 17

[Wayne Chang [:wchang]]

Triage - koi? given the discussion between comment 8 and comment 12, the bug is not obvious and requires a specific sequence of actions to show.

Comment 18

[Jack Liu]

it reproduced on Mozilla build ID:20130812041203.
The simple steps to reproduce:
1. set language to English.
2. kill settings.
3. set language to Polski.
4. enter settings->SIM security->change PIN.
5. you'll find '3 tries left' on the top. --KO

mark leo? again.

Comment 19

[Dietrich Ayala (:dietrich)]

Marking blocking per https://etherpad.mozilla.org/b2g-triage-exceptions. Localization peeps, let us know if this is even a remote possibility at this stage.

If not, we'll push to koi.

Comment 20

[Axel Hecht [:Pike]]

We don't know where this bug is coming from, and I think the fix is going to be to keep this UI from showing at all, there should never be a UX that says "3 tries left", IMHO.

This seems to be only happening in the vendor build, tool

Comment 21

[Joe Cheng [:jcheng] (please needinfo)]

Attachment: 2013-08-27-16-16-27.png

cannot reproduce on partner 08/23 build

Comment 22

[Joe Cheng [:jcheng] (please needinfo)]

is this still a problem? please see comment 21
thanks

Comment 23

[Joe Cheng [:jcheng] (please needinfo)]

move this to koi
this seems to happen sometimes if you goto this Enter PIN page right after you change language but i cannot reproduce consistently. User impact is low

Comment 24

[Axel Hecht [:Pike]]

Joe, did you resolve this WORKSFORME on purpose?

Comment 25

[Jack Liu]

still reproduced on latest moz Build 20130902041201, follow STR in comment#18.
also reproduced by below STR:
 
1. set language to English.
2. kill settings.
3. set language to Polski.
4. turn off plane mode then turn on it.
5. you'll find '3 tries left' on the top of input SIM pin page. --KO

Comment 27

[Andrew Overholt [:overholt]]

It seems there is some confusion over where this reproduces (commercial or reference RIL).

QA, can you test this with both RILs and verify the current behaviour?  Thanks!

Comment 28

[Natalya Kot [:nkot]]

Attachment: v1.1 - Vendor/COM-RIL/MOZ-RIL

have tested on the following v1.1 builds: Vendor, COM-RIL, MOZ-RIL

Vendor  - Reproduces
COM-RIL - Reproduces 
MOZ-RIL - Does NOT Reproduce 

STR:
1. Enable SIM security in Settings
2. Restart device
3. Tap home button to skip entering SIM PIN when promted after powered on
4. Set language to Polish in Settings
5. Longpress power button -> enable Airplane mode
6. Longpress power button -> disable Airplane mode

Vendor build (US_20120912)
 
Build ID: 20130918041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6b8a7556ab2e
Gaia: 7310d9fd969db201bdc9ff275a3ac8b537f7070a
Platform Version: 18.1

for COM-RIL:
RIL Version: 01.01.00.019.227

Comment 29

[Andrew Overholt [:overholt]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12344#attch-to-bugzilla

Pointer to Github pull-request

Comment 30

[Andrew Overholt [:overholt]]

Comment on attachment 807951 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12344#attch-to-bugzilla

Simple fix as suggested by Staś in comment 6.

Comment 31

[Peter Dolanjski [:pdol]]

Given that this is on one of the first screens the user will see and the risk is very low, blocking.

Comment 32

[Ryan VanderMeulen [:RyanVM]]

This doesn't have r+ yet.

Comment 33

[Fernando Campo (:fcampo)]

Comment on attachment 807951 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12344#attch-to-bugzilla

Sorry for late review, but I was on PTO till today. 
Easy patch, no risks, thanks for spot and fix it!

Comment 34

[Julien Wajsberg [:julienw]]

master: c357e33b00d1c54774a4b0083b49457fad47afd6

Comment 35

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted c357e33b00d1c54774a4b0083b49457fad47afd6 to:
v1-train: 00757c6b53ef795b6f41b38c9e3408b0126c890f
v1.2: c0411b513e6cce4c635343560da9663aaaea3d26

Comment 36

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 00757c6b53ef795b6f41b38c9e3408b0126c890f