Remove all code referencing author.

RESOLVED FIXED

Status

Webmaker
Popcorn Maker
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mjschranz, Assigned: mjschranz)

Tracking

Details

(Whiteboard: s=2013w24 p=1)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We aren't really allowing for custom author input like we were before. This is being replaced by login username/subdomain.

Updated

4 years ago
Whiteboard: s=2013w23
(Assignee)

Comment 1

4 years ago
Created attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

This covers removal of old code and replacement of author with username.
Attachment #757533 - Flags: review?(jon)

Comment 2

4 years ago
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

This needs a migration script, but I'm not sure the migration script should remove the author column. Perhaps we want to keep it around for when people migrate their Popcorn Maker account to a Webmaker account? Not sure here.

We shouldn't land this until the user bar has landed; otherwise people will not able to set their username without signing in somewhere else first.

The code looks good though! Provisional r+
Attachment #757533 - Flags: review?(jon) → review+
(Assignee)

Updated

4 years ago
Depends on: 878963

Updated

4 years ago
Whiteboard: s=2013w23 → s=2013w24

Updated

4 years ago
Whiteboard: s=2013w24 → s=2013w24 p=1
Severity: normal → blocker
(Assignee)

Comment 3

4 years ago
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

Quick lookover before landing code as it's had to rebase around recent changes.
Attachment #757533 - Flags: review+ → review?(jon)

Updated

4 years ago
Attachment #757533 - Flags: review?(jon) → review-

Comment 4

4 years ago
Bah, hit the button too quick. There's two rebase problems noted in the pull request, and you need to add a MySQL migration script to remove the author column.
(Assignee)

Comment 5

4 years ago
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

Redo using information that was already available to me.
Attachment #757533 - Flags: review- → review?(jon)
(Assignee)

Comment 6

4 years ago
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

Relieving Jon a bit.
Attachment #757533 - Flags: review?(jon) → review?(david.humphrey)
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

You've got Travis fails to deal with here still.  Fix those and bounce back to me when it's green.

https://s3.amazonaws.com/archive.travis-ci.org/jobs/7991832/log.txt
Attachment #757533 - Flags: review?(david.humphrey) → review-

Comment 8

4 years ago
Those travis fails have been in there for awhile
(Assignee)

Comment 9

4 years ago
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

The failing tests are well documented. See https://bugzilla.mozilla.org/show_bug.cgi?id=877772 and https://bugzilla.mozilla.org/show_bug.cgi?id=873597.

Basically, it's known that there are a lot of problems. At this point I think our solution is to wait until the big server code rewrite to handle this and get things back on track then.
Attachment #757533 - Flags: review- → review?(david.humphrey)
Comment on attachment 757533 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/31

A couple minor things to consider in the PR, r+ after that.  I think this can land with those resolved/decided.
Attachment #757533 - Flags: review?(david.humphrey) → review+

Comment 11

4 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/ebd3f92cd1bbeca5be79e95294a4b439f66d08d7
Fix Bug 878774 - Remove all references of custom author input. Replace with username from login api

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.