Closed Bug 878808 Opened 12 years ago Closed 12 years ago

[SMS] When focusing the input area, the cursor position should not be lost to the scroll

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 verified)

VERIFIED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- verified

People

(Reporter: gnarf, Assigned: kaze)

References

Details

Attachments

(1 file)

I'm not sure if we want to do something about this. Steps: * Add two or three images * tap on the bottom of the message to start typing text Expected: * You can see where you will be typing Actual: * Because the height of the box changes, the cursor is well below the scrollable area ---- if you type anything, the scroll is updated correctly I think we could detect where the focus is and update the scrollTop when we do this
Summary: [SMS] When focusing the input area, the cursor position can be lost to the scroll → [SMS] When focusing the input area, the cursor position should not be lost to the scroll
Depends on: 877776
Must fix. Not acceptable to have to type blind.
blocking-b2g: --- → leo+
Assignee: nobody → kaze
I can’t reproduce this bug with the master branch. Maybe it’s been fixed along with bug 877776… Naoki, Mike, can you confirm this bug still occurs?
Flags: needinfo?(nhirata.bugzilla)
Flags: needinfo?(mike)
The patch for bug 877776 helped us identify this as a previously-existing problem. As it stands, I can still reproduce on `master` (93cfac235cba8c4131da71386a56f23ddb60fb61).
Flags: needinfo?(mike)
Thanks Mike. I saw the container size issue, working on it.
Flags: needinfo?(nhirata.bugzilla)
Ugh, the container issue I was referring to was described… and fixed in bug 877683.
Depends on: 877683
(In reply to Dietrich Ayala (:dietrich) from comment #1) > Must fix. Not acceptable to have to type blind. yep must fix form a UX perspective as well. Can you also ensure that you put me on CC for any bugs that are opened regarding the messaging (SMS or MMS) app please. Thanks
Comment on attachment 758711 [details] link to pull request I really still don't understand the magic number issue in the comments. Could you try again to explain why you can't just assign scrollTop a value you get from the clientRect?
Attachment #758711 - Flags: review?(mike) → review?(gnarf37)
Corey, I’ve just updated the pull request according to your suggestions, please have another look.
Comment on attachment 758711 [details] link to pull request Thanks! This works as expected, and has less magic numbering than we started with :) r=me
Attachment #758711 - Flags: review?(gnarf37) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-moztrap?
Uplifted 8c5c7bac8b1895033ea7e9956453335db4d6aa97 to: v1-train: b7ee2e483098696ebf873f93edbdc4f24bccbdd8
Flags: in-moztrap? → in-moztrap+
Added SMS Suite Test Case #8563 [SMS] The text cursor remains visible while focusing on the SMS attachment input area
The user is able to see the cursor while focusing on the SMS input area. Issue seems to be fixed so changing to verified fixed. Environmental Variables Leo Build ID: 20130807071207 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff Gaia: 60ca81600a080dae33058b0692ecaa213556c926 Platform Version: 18.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: