878808 - [SMS] When focusing the input area, the cursor position should not be lost to the scroll

Status: VERIFIED FIXED

Description

[Corey Frang [:gnarf]]

I'm not sure if we want to do something about this.

Steps:
* Add two or three images
* tap on the bottom of the message to start typing text

Expected:
* You can see where you will be typing

Actual:
* Because the height of the box changes, the cursor is well below the scrollable area

----

if you type anything, the scroll is updated correctly

I think we could detect where the focus is and update the scrollTop when we do this

Comment 1

[Dietrich Ayala (:dietrich)]

Must fix. Not acceptable to have to type blind.

Comment 2

[Fabien Cazenave [:kaze]]

I can’t reproduce this bug with the master branch. Maybe it’s been fixed along with bug 877776…

Naoki, Mike, can you confirm this bug still occurs?

Comment 3

[Mike Pennisi [:jugglinmike]]

The patch for bug 877776 helped us identify this as a previously-existing problem.  As it stands, I can still reproduce on `master` (93cfac235cba8c4131da71386a56f23ddb60fb61).

Comment 4

[Fabien Cazenave [:kaze]]

Thanks Mike. I saw the container size issue, working on it.

Comment 5

[Fabien Cazenave [:kaze]]

Ugh, the container issue I was referring to was described… and fixed in bug 877683.

Comment 6

[ayman maat :maat]

(In reply to Dietrich Ayala (:dietrich) from comment #1)
> Must fix. Not acceptable to have to type blind.

yep must fix form a UX perspective as well. Can you also ensure that you put me on CC for any bugs that are opened regarding the messaging (SMS or MMS) app please.

Thanks

Comment 7

[Fabien Cazenave [:kaze]]

Created attachment 758711 [details]
link to pull request

https://github.com/mozilla-b2g/gaia/pull/10221

Comment 8

[Corey Frang [:gnarf]]

Comment on attachment 758711 [details]
link to pull request

I really still don't understand the magic number issue in the comments.  Could you try again to explain why you can't just assign scrollTop a value you get from the clientRect?

Comment 9

[Fabien Cazenave [:kaze]]

Corey, I’ve just updated the pull request according to your suggestions, please have another look.

Comment 10

[Corey Frang [:gnarf]]

Comment on attachment 758711 [details]
link to pull request

Thanks! This works as expected, and has less magic numbering than we started with :)

r=me

Comment 11

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/8c5c7bac8b1895033ea7e9956453335db4d6aa97

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8c5c7bac8b1895033ea7e9956453335db4d6aa97 to:
v1-train: b7ee2e483098696ebf873f93edbdc4f24bccbdd8

Comment 13

[:CSchmoeckel]

Added SMS Suite Test Case #8563 [SMS] The text cursor remains visible while focusing on the SMS attachment input area

Comment 14

[Deepa Subramanian]

The user is able to see the cursor while focusing on the SMS input area.
Issue seems to be fixed so changing to verified fixed.

Environmental Variables
Leo Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1