Closed
Bug 878814
Opened 11 years ago
Closed 11 years ago
Add webidl support for permissions tests
Categories
(Core :: Permission Manager, defect)
Core
Permission Manager
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dchanm+bugzilla, Assigned: dchanm+bugzilla)
References
Details
Attachments
(1 file)
|
2.50 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
The current test framework requires XPIDLs for instanceof checks. WebIDLs don't necessarily return those types causing test failures.
|
Assignee | |
Comment 1•11 years ago
|
||
Pending try run https://tbpl.mozilla.org/?tree=Try&rev=9c54fad83987 This patch adds webidl support by creating another key for gData. Either webidl or idl is used for permissions tests.
Attachment #757528 -
Flags: review?(amarchesini)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 757528 [details] [diff] [review] Add webidl support Review of attachment 757528 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #757528 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Try run was green. Tests won't start using this new functionality until bug 875784 lands
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fde84a623e9
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8fde84a623e9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•