MarkCycleCollectorChildren should mark the global

RESOLVED INCOMPLETE

Status

()

Core
JavaScript Engine
RESOLVED INCOMPLETE
5 years ago
7 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
I noticed that MarkCycleCollectorChildren and ScanBaseShape are inconsistent.  In the latter we attempt to trace the global if the base shape has no parent, but MarkCycleCollectorChildren wasn't updated to do this when this was changed, about a year ago.  It probably doesn't matter much in practice because a lot of things reach the global?  I'll also add a comment about keeping MarkCycleCollectorChildren and ScanBaseShape in sync.

This would be prevented by my horrible proposal to generate the various marking paths via horrible templates!
(Assignee)

Comment 1

5 years ago
I'll wait until bug 878583 lands to avoid gratuitous bitrotting of a more important patch...
Depends on: 878583
(Assignee)

Comment 2

5 years ago
I think this was a regression in bug 687724.
(Assignee)

Comment 3

5 years ago
This newly added bit needs to be synced up as well:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8d612ac461
(Assignee)

Comment 4

7 months ago
I don't remember what this was about.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.