Closed Bug 878865 Opened 11 years ago Closed 7 years ago

MarkCycleCollectorChildren should mark the global

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

I noticed that MarkCycleCollectorChildren and ScanBaseShape are inconsistent.  In the latter we attempt to trace the global if the base shape has no parent, but MarkCycleCollectorChildren wasn't updated to do this when this was changed, about a year ago.  It probably doesn't matter much in practice because a lot of things reach the global?  I'll also add a comment about keeping MarkCycleCollectorChildren and ScanBaseShape in sync.

This would be prevented by my horrible proposal to generate the various marking paths via horrible templates!
I'll wait until bug 878583 lands to avoid gratuitous bitrotting of a more important patch...
Depends on: 878583
I think this was a regression in bug 687724.
This newly added bit needs to be synced up as well:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8d612ac461
I don't remember what this was about.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.