878876 - Pass through package size for packaged apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P5)

Description

[Andy McKay]

The bango api takes a size of an app. That's pointless for hosted apps at this point, so we just set at some small number. Ideally now we have packaged apps, we should be sending through the size of the packaged app. However I don't think this is used anywhere yet, so it's low priority.

Comment 1

[Rob Hudson [:robhudson]]

We store the pre-signed size in the files table's "size" column.

Comment 2

[Kumar McMillan [:kumar]]

Does this bug cover passing the data all the way from Zamboni to Bango?

Also, this is a tricky scenario because the navigator.mozPay() API does not have a "package size" data point and that is too specific to apps anyway. The mozPay() API is used for all in-app payments which may or may not be downloadable products.

Comment 3

[Andy McKay]

(In reply to Kumar McMillan [:kumar] from comment #2)
> Does this bug cover passing the data all the way from Zamboni to Bango?

That was my plan.

> Also, this is a tricky scenario because the navigator.mozPay() API does not
> have a "package size" data point and that is too specific to apps anyway.
> The mozPay() API is used for all in-app payments which may or may not be
> downloadable products.

Is this worth doing then, or should we not bother? I was mostly wanting to implement the API as provided by Bango.

Comment 4

[Andy McKay]

The size is called on billing configuration. There's a field in the JWT called productData that we can use for pretty much anything. Unfortunately this means the bug needs to be done in a few parts:

1) add in size from the file productData to the prepare JWT call

https://github.com/andymckay/zamboni/blob/master/mkt/purchase/webpay.py#L113

2) sniff it in webpay, default should be zero

3) then pass it from webpay down to solitude when webpay calls billing:

https://github.com/mozilla/webpay/blob/master/lib/solitude/api.py#L201

4) finally alter solitude end point to accept that and pass it on to bango

Comment 5

[Kumar McMillan [:kumar]]

Here is an example of where we already sniff productData https://github.com/mozilla/webpay/blob/master/webpay/pay/tasks.py#L126 It's not ideal but the alternative is to define some kind of recognized data exchange format (perhaps with JSON-LD namespaces) so that is future work.

Comment 6

[David Larlet [:davidbgk]]

Here are 3 pull-requests related to that bug:

* zamboni: https://github.com/mozilla/zamboni/pull/912
* webpay: https://github.com/mozilla/webpay/pull/203
* solitude: https://github.com/mozilla/solitude/pull/114

Comment 7

[David Larlet [:davidbgk]]

https://github.com/mozilla/zamboni/commit/7853d2e43d9a40f789ea32752c0c01e0ac105f02
https://github.com/mozilla/webpay/commit/b54637b8ab24772e85e1a65991c77c3a44500df1
https://github.com/mozilla/solitude/commit/6db7f14360f590084a459fbd5add609fb2221a91

Comment 8

[Andy McKay]

Reverted the webpay and solitude ones because of:

https://sentry.prod.solitude.allizomaws.com/amo/paymentsfirefoxcom/group/32/

Sounds like an error in the XML, we shouldn't be passing through application_size.

I think application_size is being added to the data and it shouldn't be, you might need to delete it so it doesn't show up in bango data:

https://github.com/mozilla/solitude/compare/2013.07.24...2013.07.25#L0L212

Comment 9

[David Larlet [:davidbgk]]

Agreed, I should have been more careful, here is the updated pull-request to pop the info from the data passed to Bango:

https://github.com/mozilla/solitude/pull/117

Comment 10

[Kumar McMillan [:kumar]]

Ugh, we didn't catch this on dev because I don't think dev ever auto-updated with your changes when we first merged to master. The gunicorn->uswgi switch seemed to cause a lot of instability on dev this week.

Comment 11

[Kumar McMillan [:kumar]]

I was able to get to the Bango payment flow on dev after this change landed on dev: https://github.com/mozilla/solitude/commit/8f73198df79d906a18eab636be63b1436629a480

Thanks!

Comment 12

[Victor Carciu]

Can you please add some STRs to this bug or mark it as [qa-] ?