Closed
Bug 878898
Opened 11 years ago
Closed 11 years ago
Rename 'name' to 'label' for Australis widgets
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M?][Australis:P5])
Attachments
(1 file)
As mentioned in bug 868433, renaming the 'name' property of a widget to 'label' was discussed, to mirror the button node property names. In that bug we already renamed the 'description' property to 'tooltiptext' with the same reason.
Comment 1•11 years ago
|
||
Calling this P5 since there's no user impact, but if we're going to do this we should do it ASAP to minimize API churn. Mike, you want to Just Do It?
Flags: needinfo?(mdeboer)
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P5]
Assignee | ||
Comment 2•11 years ago
|
||
There were some leftovers to rename 'description' to 'tooltiptext' for the widget wrappers, so I also took care of that to consolidate the public API before landing.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Attachment #770196 -
Flags: review?(jaws)
Flags: needinfo?(mdeboer)
Updated•11 years ago
|
Attachment #770196 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 3•11 years ago
|
||
http://hg.mozilla.org/projects/ux/rev/26608ffcc23c
Whiteboard: [Australis:M?][Australis:P5] → [Australis:M?][Australis:P5][fixed-in-ux]
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26608ffcc23c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M?][Australis:P5][fixed-in-ux] → [Australis:M?][Australis:P5]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•