Rename 'name' to 'label' for Australis widgets

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mikedeboer, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 28
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M?][Australis:P5])

Attachments

(1 attachment)

As mentioned in bug 868433, renaming the 'name' property of a widget to 'label' was discussed, to mirror the button node property names.

In that bug we already renamed the 'description' property to 'tooltiptext' with the same reason.
Calling this P5 since there's no user impact, but if we're going to do this we should do it ASAP to minimize API churn.

Mike, you want to Just Do It?
Flags: needinfo?(mdeboer)
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P5]
Created attachment 770196 [details] [diff] [review]
v1: Rename 'name' and 'description' properties to 'label' and 'tooltiptext' respectively

There were some leftovers to rename 'description' to 'tooltiptext' for the widget wrappers, so I also took care of that to consolidate the public API before landing.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Attachment #770196 - Flags: review?(jaws)
Flags: needinfo?(mdeboer)
Attachment #770196 - Flags: review?(jaws) → review+
http://hg.mozilla.org/projects/ux/rev/26608ffcc23c
Whiteboard: [Australis:M?][Australis:P5] → [Australis:M?][Australis:P5][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/26608ffcc23c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M?][Australis:P5][fixed-in-ux] → [Australis:M?][Australis:P5]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.