Closed
Bug 878914
Opened 11 years ago
Closed 11 years ago
Minor race condition in marionette run_tests.py
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
This is unlikely to be a problem in practice but the way marionette gets an open port for its http server is racey. Instead of getting a port number by opening a socket ourselves, we should just let mozhttpd do that for us. This was actually implemented in a released version of marionette (0.5.28). This bug is just about getting those changes landed in m-c.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → wlachance
Attachment #757521 -
Flags: review?(jgriffin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 757521 [details] [diff] [review] Fix race condition, bump version number Review of attachment 757521 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #757521 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Inbound (minus the version bump, since we're already at 0.5.29): https://hg.mozilla.org/integration/mozilla-inbound/rev/2dd5420680af
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2dd5420680af
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•