878918 - Android compatible packaged apps aren't shown in search on android

Status: VERIFIED FIXED

(Marketplace Graveyard :: Search, defect, P2)

Description

[Wil Clouser [:clouserw]]

STR:

1) Load marketplace.firefox.com in Firefox Aurora on your mobile phone
2) Search for "Kitchen Sink"

(There are more examples of packaged apps if you need them)

Expected Results:
- See Kitchen Sink search result

Actual Resuts:
- A message saying "No results found"

Comment 1

[Rob Hudson [:robhudson]]

I loaded this on my old android phone. The app hit the API url:
https://marketplace-dev.allizom.org/api/v1/apps/search/?dev=android&device=mobile&lang=en-US&pro=ea7dd7fc.32.1&q=kitchen&region=us

These are the filters being applied from the logs:

u'filter': {u'and': [{u'term': {u'status': 4}},
                     {u'term': {u'type': 11}},
                     {u'term': {u'is_disabled': False}},
                     {u'term': {u'uses_flash': False}},
                     {u'term': {u'app_type': 1}},
                     {u'not': {u'filter': {u'and': [{u'range': {u'price': {u'gt': 0}}},
                                                    {u'in': {u'premium_type': [1, 2]}}]}}},
                     {u'term': {u'device': 2}}]},

A couple notes...

app_type: 1 means it's only looking for hosted apps. We're making the assumption that since we're on android we don't want packaged apps. Should we open up packaged apps for android devices (i.e. not filter by app_type:1)?

device: 2 means we're looking for apps that support android. According to the kitchensink apps page, it only supports Firefox OS (https://marketplace-dev.allizom.org/developers/app/kitchensink/payments/). I think our logic is correct here, but the app should be updated that it supports Firefox Mobile.

Comment 2

[Bill Walker [:bwalker] [@wfwalker]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> app_type: 1 means it's only looking for hosted apps. We're making the
> assumption that since we're on android we don't want packaged apps. Should
> we open up packaged apps for android devices (i.e. not filter by app_type:1)?

Yes, please allow packaged apps to appear in searches for Android devices.

> 
> device: 2 means we're looking for apps that support android. According to
> the kitchensink apps page, it only supports Firefox OS
> (https://marketplace-dev.allizom.org/developers/app/kitchensink/payments/).
> I think our logic is correct here, but the app should be updated that it
> supports Firefox Mobile.

Yes. Wil+Piotr, please update Kitchen Sink to say that it supports Android.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

To be clear, I am able to see the Kitchen Sink listing from Fennec by going to http://marketplace.mozilla.com/app/kitchensink .

Comment 1 and comment 2 both refer to https://marketplace-dev.allizom.org .

Comment 4

[Rob Hudson [:robhudson]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #3)
> To be clear, I am able to see the Kitchen Sink listing from Fennec by going
> to http://marketplace.mozilla.com/app/kitchensink .

Yes, if you know the exact url you can get to the app. I believe there are bugs as to whether the install button will be enabled or not.

Comment 5

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/c30c449 

To verify:
Submit a free packaged app and make sure firefox mobile is a device type. After approval verify a search for your packaged app from an android device finds your app.

Comment 6

[Caitlin Galimidi [:c8o]]

now that we actually have firefox mobile devices - isn't this going to be confusing for app developers who would like to submit an app for the android platform?

shouldn't our device choices be
- android
- firefox OS
- desktop

?

Just checking...

Comment 7

[Caitlin Galimidi [:c8o]]

never mind - ignore me.

Comment 8

[Victor Carciu]

Verified as fixed . Tried with this app : https://marketplace-dev.allizom.org/app/blesuscri-thimartse-britonz/