878921 - new doc: "select a valid choice"

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Luke Crouch [:groovecoder]]

What did you do?
================
1. go to /en-US/docs/new
2. Title: "new doc"
3. Slug: "new_doc"
4. Content: "new doc"


What happened?
==============
validation message:

"Select a valid choice. That choice is not one of the available choices." 

What should have happened?
==========================
Save the new article with no error message.

Is there anything else we should know?
======================================
I think this is caused by missing the "Needs review" checkboxes?

Comment 1

[Jesus Perez]

Hi Luke, I was working on this template so I've taken a look...

I've found that the error is in:
/kuma/apps/wiki/templates/wiki/new_document.html - line 38 : <input type="hidden" name="parent_topic" value="{{ parent_id | safe }}" />
{{ parent_id | safe }} is returning the string "None" (I think it must be empty).
Maybe a condition for parent_id != None can solve the problem?

If this is not valid (and from here I'm improvising :P)
This "parent_id", is defined in /kuma/apps/wiki/views.py - line 905  and then line 828, when the "None" becomes a string... I don't know how to solve it from here, or if I'm right...

Hope this helps

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3b5ee23bcddebecfe55a8361b264b27df9e21ad1
fix bug 979807, 878921, 953349 - Prevent first doc save error message

https://github.com/mozilla/kuma/commit/b64281dedecf2a93413f64349481c0347cd1339c
Merge pull request #2193 from darkwing/fix-valid-choice-878921

fix bug 979807, 878921, 953349 - Prevent first doc save error message