Closed Bug 878925 Opened 6 years ago Closed 6 years ago

update to latest double-conversion to fix some issues

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: xunxun1982, Assigned: ehoogeveen)

References

Details

Attachments

(1 file)

Update double-conversion to latest git revision
6.91 KB, patch
Waldo
: review+
Details | Diff | Splinter Review 
double-conversion latest git has fix a bug 

Fix double increment.

Inside double-conversion this function is only called with values that will
never trigger this bug.

http://code.google.com/p/double-conversion/source/detail?r=04cae7a8d5ef3d62ceffb03cdc3d38f258457a52

Maybe we can merge the patch or update double-conversion to latest git
Taking this bug.
Assignee: nobody → emanuel.hoogeveen
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 8 → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Not a lot to this update. I updated use-StandardInteger.patch to point to the correct line, but otherwise the patches applied fine.
Attachment #767958 - Flags: review?(jwalden+bmo)
Blocks: 887465
Attachment #767958 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/abd9f7b3ded5

Thanks!
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/abd9f7b3ded5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.