878928 - Re-enable to-element-width double-tap zooming even without reflow

Status: RESOLVED DUPLICATE of bug 878931

(Firefox for Android Graveyard :: Readability, defect)

Description

[Scott Johnson (:jwir3)]

When double-tap-to-reflow-text is enabled, and the reflow-on-zoom logic in browser.js has determined that we're already at a sufficiently large enough zoom to achieve the desired font size, double-tap does nothing. Instead, we should re-enable the behavior we previously had (and have with double-tap-to-reflow disabled) where it zooms to the element width, but does not reflow the text.

Comment 1

[Scott Johnson (:jwir3)]

Attachment: b878928

Comment 2

[Kartikaya Gupta (email:[e-mail])]

As per our last IRC discussion, the patch on this bug depends on the patch on bug 878931.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 761679 [details] [diff] [review]
b878928

Also, dropping review flag for now, based on the last IRC conversation (sorry I missed your ping yesterday evening). I don't understand why getZoomToMinFontSize returns 1.0 + stuff instead of just the "stuff", and without understanding that I can't review this patch properly.

Comment 4

[Scott Johnson (:jwir3)]

Changed were baked into bug 878931, which has now landed.