If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add a test for HTMLImageElement and fix h/vspace reflection

RESOLVED FIXED in mozilla24

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla24
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 757543 [details] [diff] [review]
Patch v1
Attachment #757543 - Flags: review?(mounir)
Comment on attachment 757543 [details] [diff] [review]
Patch v1

Review of attachment 757543 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/test_img_attributes_reflection.html
@@ +28,5 @@
> +todo("srcset" in document.createElement("img"), "Should implement srcset")
> +
> +reflectString({
> +  element: document.createElement("img"),
> +  attribute: "alt",

Did you meant to have "alt" twice?

@@ +31,5 @@
> +  element: document.createElement("img"),
> +  attribute: "alt",
> +})
> +
> +reflectString({

Shouldn't that be reflectLimitedEnumerated?

@@ +80,5 @@
> +})
> +
> +reflectString({
> +  element: document.createElement("img"),
> +  attribute: "lowsrc",

That should be reflectURL according to the spec, shouldn't it?

@@ +84,5 @@
> +  attribute: "lowsrc",
> +})
> +
> +ok("x" in document.createElement("img"), "img.x is present")
> +ok("y" in document.createElement("img"), "img.y is present")

What are those?

Also, we are missing width, height, naturalWidth and naturalHeight, right?
Attachment #757543 - Flags: review?(mounir) → review-
(Assignee)

Comment 2

4 years ago
Created attachment 760128 [details] [diff] [review]
Patch v2

I filed bugs for lowsrc (which I'm not sure we want) and crossOrigin (which I think we should change together with the other crossOrigin attributes).
Attachment #757543 - Attachment is obsolete: true
Attachment #760128 - Flags: review?(mounir)
Attachment #760128 - Flags: review?(mounir) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/mozilla-central/rev/e84d4694a553
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.