When you use the new uploading functionality, users won't know that their uploaded thumbnail works. Ideally, we would change the image that is there (the little landscape) to the thumbnail they have uploaded.
Created attachment 758595 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/36 The only issue left here is I can't set the drop area img to the dropped image when someone drops over the canvas. There's no way for me to tie that together with the editor because it's all async. I personally think we should just remove the ability to drop while the editor isn't open but that might be just me.
Attachment #758595 - Flags: review?(scott)
Correction. That's only when being used with the image event/plugin.
Comment on attachment 758595 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/36 So, I am OK with this as is. It is up to you if you want to do something about the image plugin now or later. I say later. Technically, it doesn't fall under this ticket's title.
Attachment #758595 - Flags: review?(scott) → review+
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/c6b3a4416523c29dcd2b6879381e1d362c8b8e5a Fix bug 878975 - Give users feedback by showing uploaded picture in droppable areas
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.