Closed
Bug 879010
Opened 12 years ago
Closed 12 years ago
Thimble doesn't properly store a remixedFrom
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Whiteboard: s=2013w23)
Attachments
(1 file)
It looks like originalURL is trying to be remixedFrom, but it's not quite there, and not being used for anything else.
I have a patch in the works for bug 876441 but decided to split it up, and get it properly storing an originalURL being the page it originated from.
It looks like this is getting confused as to the originalURL from the page url at the time of a pubish, which isn't quite what it should be.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
The main goal of this is we're no longer reading the page url for project id, but getting it from req.params.id.
Attachment #757606 -
Flags: review?(pomax)
Comment on attachment 757606 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/93
excellent idea.
Attachment #757606 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/59571bad825174167ebbc582a6189da7ab5c8854
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•