Closed Bug 879011 Opened 6 years ago Closed 6 years ago

Add pixel units to nsInputEvent and friends

Categories

(Core :: Graphics, defect)

23 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(3 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #877728 +++

Follow-up from bug 865735 - this is an incremental propagation of pixel-units information to some uses of gfx::Point, gfx::Size, gfx::Rect and nsIntPoint.
Comment on attachment 761045 [details] [diff] [review]
Part 1 - Type input event points as screen coordinates

Review of attachment 761045 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/AsyncPanZoomController.h
@@ +550,1 @@
>  

int -> float fix hidden inside a refactoring. Is it worth putting this in a separate patch?
Attachment #761045 - Flags: review?(ajones) → review+
Attachment #761047 - Flags: review?(ajones) → review+
Makes sense. I split out the int -> float conversion here, carrying r+
Attachment #761182 - Flags: review+
And the actual conversion is here. Also carrying r+
Attachment #761045 - Attachment is obsolete: true
Attachment #761183 - Flags: review+
You need to log in before you can comment on or make changes to this bug.