Add pixel units to nsInputEvent and friends

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

23 Branch
mozilla24
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #877728 +++

Follow-up from bug 865735 - this is an incremental propagation of pixel-units information to some uses of gfx::Point, gfx::Size, gfx::Rect and nsIntPoint.
Created attachment 761045 [details] [diff] [review]
Part 1 - Type input event points as screen coordinates
Attachment #761045 - Flags: review?(ajones)
Created attachment 761047 [details] [diff] [review]
Part 2 - Make APZC::ScrollBy take a CSSPoint
Attachment #761047 - Flags: review?(ajones)
Comment on attachment 761045 [details] [diff] [review]
Part 1 - Type input event points as screen coordinates

Review of attachment 761045 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/AsyncPanZoomController.h
@@ +550,1 @@
>  

int -> float fix hidden inside a refactoring. Is it worth putting this in a separate patch?
Attachment #761045 - Flags: review?(ajones) → review+
Attachment #761047 - Flags: review?(ajones) → review+
Created attachment 761182 [details] [diff] [review]
Part 1a - int to float conversion in APZC

Makes sense. I split out the int -> float conversion here, carrying r+
Attachment #761182 - Flags: review+
Created attachment 761183 [details] [diff] [review]
Part 1b - Type input event points as screen coordinates

And the actual conversion is here. Also carrying r+
Attachment #761045 - Attachment is obsolete: true
Attachment #761183 - Flags: review+

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/78ce97fe40bc
https://hg.mozilla.org/mozilla-central/rev/992ca64ed476
https://hg.mozilla.org/mozilla-central/rev/1f1742107151
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.