Closed
Bug 879011
Opened 11 years ago
Closed 11 years ago
Add pixel units to nsInputEvent and friends
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(3 files, 1 obsolete file)
7.65 KB,
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
7.61 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
23.25 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #877728 +++ Follow-up from bug 865735 - this is an incremental propagation of pixel-units information to some uses of gfx::Point, gfx::Size, gfx::Rect and nsIntPoint.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #761045 -
Flags: review?(ajones)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #761047 -
Flags: review?(ajones)
Assignee | ||
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c3cd39b12b2b
Comment 4•11 years ago
|
||
Comment on attachment 761045 [details] [diff] [review] Part 1 - Type input event points as screen coordinates Review of attachment 761045 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/ipc/AsyncPanZoomController.h @@ +550,1 @@ > int -> float fix hidden inside a refactoring. Is it worth putting this in a separate patch?
Attachment #761045 -
Flags: review?(ajones) → review+
Updated•11 years ago
|
Attachment #761047 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Makes sense. I split out the int -> float conversion here, carrying r+
Attachment #761182 -
Flags: review+
Assignee | ||
Comment 6•11 years ago
|
||
And the actual conversion is here. Also carrying r+
Attachment #761045 -
Attachment is obsolete: true
Attachment #761183 -
Flags: review+
Assignee | ||
Comment 7•11 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/78ce97fe40bc remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/992ca64ed476 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f1742107151
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/78ce97fe40bc https://hg.mozilla.org/mozilla-central/rev/992ca64ed476 https://hg.mozilla.org/mozilla-central/rev/1f1742107151
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•