If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

IDL checking hook incorrectly blocks changes to .webidl files

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mccr8, Assigned: Ms2ger)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Changes to WebIDL files (ending in '.webidl') are being blocked by the IDL checking hook.  WebIDL isn't XPIDL, and doesn't have UUIDs to change.

I think there is a bug in this line from the script:
  if file.endswith('idl'):

A file that ends in '.webidl' also ends in 'idl', which I'm guessing must be the problem.  Presumably changing 'idl' to '.idl' would fix it, though I don't know if there are any other wacky endings you'd want to catch.
(Reporter)

Comment 1

4 years ago
FWIW, this was mentioned in review of the patch.
https://bugzilla.mozilla.org/show_bug.cgi?id=813809#c9
(Assignee)

Comment 2

4 years ago
Created attachment 757970 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #757970 - Flags: review?(ted)
Attachment #757970 - Flags: review?(ted) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/hgcustom/hghooks/rev/e40e353145af

No hurry to get this deployed in particular, I guess.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Depends on: 891913
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.