Closed
Bug 879134
Opened 12 years ago
Closed 11 years ago
Remove obsolete CFM migration code from nsNSSComponent
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file)
|
6.69 KB,
patch
|
cviecco
:
review+
wtc
:
review+
|
Details | Diff | Splinter Review |
See bug 173369, fixed circa 2005. I think we can be confident that these migrations are no longer needed. I don't have a Mac, so I didn't test this. But, I did send it to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=cd2a1e949af1
Attachment #757797 -
Flags: superreview?(honzab.moz)
Attachment #757797 -
Flags: review?(cviecco)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent
Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------
Need to rebased/updated to be before the CRL change.
Attachment #757797 -
Flags: review?(cviecco) → review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent
Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------
r=wtc.
::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +1200,5 @@
> }
> }
> else
> {
>
You can remove this blank line, too.
Attachment #757797 -
Flags: review+
|
Assignee | |
Updated•11 years ago
|
Attachment #757797 -
Flags: superreview?(honzab.moz)
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/022e0c982ca3
Thanks for the reviews.
OS: Windows 7 → Mac OS X
Hardware: x86_64 → All
|
||
Comment 5•11 years ago
|
||
Great. Sorry I didn't make it here, but even sr "only" I felt responsibility to check this was at all a good idea, so it wasn't just to overlook top level changes for me, same for bug 879135.
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #5)
> Great. Sorry I didn't make it here, but even sr "only" I felt
> responsibility to check this was at all a good idea, so it wasn't just to
> overlook top level changes for me, same for bug 879135.
No problem. In this case, both wtc and cviecco reviewed it.
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•