Remove obsolete CFM migration code from nsNSSComponent

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

unspecified
mozilla24
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent

See bug 173369, fixed circa 2005. I think we can be confident that these migrations are no longer needed. I don't have a Mac, so I didn't test this. But, I did send it to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=cd2a1e949af1
Attachment #757797 - Flags: superreview?(honzab.moz)
Attachment #757797 - Flags: review?(cviecco)
Duplicate of this bug: 512837
Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent

Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------

Need to rebased/updated to be before the CRL change.
Attachment #757797 - Flags: review?(cviecco) → review+

Comment 3

5 years ago
Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent

Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +1200,5 @@
>        }
>      }
>      else
>      {
>  

You can remove this blank line, too.
Attachment #757797 - Flags: review+
Attachment #757797 - Flags: superreview?(honzab.moz)
https://hg.mozilla.org/integration/mozilla-inbound/rev/022e0c982ca3

Thanks for the reviews.
OS: Windows 7 → Mac OS X
Hardware: x86_64 → All
Great.  Sorry I didn't make it here, but even sr "only" I felt responsibility to check this was at all a good idea, so it wasn't just to overlook top level changes for me, same for bug 879135.
(In reply to Honza Bambas (:mayhemer) from comment #5)
> Great.  Sorry I didn't make it here, but even sr "only" I felt
> responsibility to check this was at all a good idea, so it wasn't just to
> overlook top level changes for me, same for bug 879135.

No problem. In this case, both wtc and cviecco reviewed it.
https://hg.mozilla.org/mozilla-central/rev/022e0c982ca3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.