879134 - Remove obsolete CFM migration code from nsNSSComponent

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Remove CFM migration code from nsNSSComponent

See bug 173369, fixed circa 2005. I think we can be confident that these migrations are no longer needed. I don't have a Mac, so I didn't test this. But, I did send it to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=cd2a1e949af1

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent

Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------

Need to rebased/updated to be before the CRL change.

Comment 3

[Wan-Teh Chang]

Comment on attachment 757797 [details] [diff] [review]
Remove CFM migration code from nsNSSComponent

Review of attachment 757797 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +1200,5 @@
>        }
>      }
>      else
>      {
>  

You can remove this blank line, too.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/022e0c982ca3

Thanks for the reviews.

Comment 5

[Honza Bambas (:mayhemer)]

Great.  Sorry I didn't make it here, but even sr "only" I felt responsibility to check this was at all a good idea, so it wasn't just to overlook top level changes for me, same for bug 879135.

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Honza Bambas (:mayhemer) from comment #5)
> Great.  Sorry I didn't make it here, but even sr "only" I felt
> responsibility to check this was at all a good idea, so it wasn't just to
> overlook top level changes for me, same for bug 879135.

No problem. In this case, both wtc and cviecco reviewed it.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/022e0c982ca3