Closed
Bug 879135
Opened 9 years ago
Closed 9 years ago
Remove dead code from nsNSSComponent
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(2 files)
8.58 KB,
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
2.82 KB,
patch
|
cviecco
:
review+
|
Details | Diff | Splinter Review |
This function has been dead code for a while. It was added in bug 100215 and now we remember the certs in a different way. The other code added in bug 100215 was already removed previously.
Attachment #757799 -
Flags: superreview?(honzab.moz)
Attachment #757799 -
Flags: review?(cviecco)
Assignee | ||
Updated•9 years ago
|
Summary: Remove nsNSSComponent::RememberCert (dead code) → Remove dead code from nsNSSComponent
Assignee | ||
Comment 1•9 years ago
|
||
This was used by the old support for signed scripts. Signed script support was removed some time in the last few months.
Attachment #757805 -
Flags: superreview?(honzab.moz)
Attachment #757805 -
Flags: review?(cviecco)
Assignee | ||
Updated•9 years ago
|
Attachment #757799 -
Attachment description: Remove nsNSSComponent::RememberCert → Part 1: Remove nsNSSComponent::RememberCert
Comment 2•9 years ago
|
||
Comment on attachment 757799 [details] [diff] [review] Part 1: Remove nsNSSComponent::RememberCert Review of attachment 757799 [details] [diff] [review]: ----------------------------------------------------------------- Almost perfect (I like remove deadcode patches).However, when testing locally (after a recent rebase) showed that a header declaration was needed in a later patch. Otherwise this would have been and r+ ::: security/manager/ssl/src/nsNSSComponent.h @@ -26,5 @@ > #include "nsSmartCardMonitor.h" > #endif > #include "nsINSSErrorsService.h" > #include "nsNetUtil.h" > -#include "nsHashtable.h" A more recent patch requires this header. Do not remove.
Attachment #757799 -
Flags: review?(cviecco) → review-
Comment 3•9 years ago
|
||
Comment on attachment 757805 [details] [diff] [review] Part 2: Remove mScriptSecurityManager Review of attachment 757805 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #757805 -
Flags: review?(cviecco) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 757799 [details] [diff] [review] Part 1: Remove nsNSSComponent::RememberCert cviecco, I fixed the issue you noted and landed this: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c033a95ef26
Attachment #757799 -
Flags: superreview?(honzab.moz)
Attachment #757799 -
Flags: review-
Attachment #757799 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 757805 [details] [diff] [review] Part 2: Remove mScriptSecurityManager Honza, I looked over this again and it isn't worth your time to look at it. It's just trivial dead code removal and it was already reviewed by cviecco. https://hg.mozilla.org/integration/mozilla-inbound/rev/6876a29a65db
Attachment #757805 -
Flags: superreview?(honzab.moz)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3c033a95ef26 https://hg.mozilla.org/mozilla-central/rev/6876a29a65db
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•