879138 - Silence GCC warnings about inline functions used but not defined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

A few of these have snuck back in (see bug 728423).

There was also an unrelated warning about "attributes" on a forward declaration being ignored since the definition had already been seen:

    class JS_FRIEND_API(AutoEnterPolicy);

The patch fixes both.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Jason Orendorff [:jorendorff]]

These GCC warnings eventually turn into errors (if no other compilation unit causes GCC to emit code for the inline function -- and I'm not totally sure what triggers that) and that's what's been holding up bug 872416.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 757806 [details] [diff] [review]
v1

Review of attachment 757806 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c7c358d0beec

Comment 5

[Jason Orendorff [:jorendorff]]

By the time this patch landed, another few GCC warnings of this kind had been added. :-\

I'll fix them in bug 879831.