Silence GCC warnings about inline functions used but not defined

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

unspecified
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

A few of these have snuck back in (see bug 728423).

There was also an unrelated warning about "attributes" on a forward declaration being ignored since the definition had already been seen:

    class JS_FRIEND_API(AutoEnterPolicy);

The patch fixes both.
Posted patch v1Splinter Review
Assignee: general → jorendorff
Attachment #757806 - Flags: review?(jwalden+bmo)
These GCC warnings eventually turn into errors (if no other compilation unit causes GCC to emit code for the inline function -- and I'm not totally sure what triggers that) and that's what's been holding up bug 872416.
Blocks: 872416
Comment on attachment 757806 [details] [diff] [review]
v1

Review of attachment 757806 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.
Attachment #757806 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/c7c358d0beec
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
By the time this patch landed, another few GCC warnings of this kind had been added. :-\

I'll fix them in bug 879831.
You need to log in before you can comment on or make changes to this bug.