Closed
Bug 879138
Opened 12 years ago
Closed 12 years ago
Silence GCC warnings about inline functions used but not defined
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
|
10.96 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
A few of these have snuck back in (see bug 728423).
There was also an unrelated warning about "attributes" on a forward declaration being ignored since the definition had already been seen:
class JS_FRIEND_API(AutoEnterPolicy);
The patch fixes both.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: general → jorendorff
Attachment #757806 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 2•12 years ago
|
||
These GCC warnings eventually turn into errors (if no other compilation unit causes GCC to emit code for the inline function -- and I'm not totally sure what triggers that) and that's what's been holding up bug 872416.
Blocks: 872416
|
||
Comment 3•12 years ago
|
||
Comment on attachment 757806 [details] [diff] [review]
v1
Review of attachment 757806 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing review.
Attachment #757806 -
Flags: review?(jwalden+bmo) → review+
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
Assignee | |
Comment 5•12 years ago
|
||
By the time this patch landed, another few GCC warnings of this kind had been added. :-\
I'll fix them in bug 879831.
You need to log in
before you can comment on or make changes to this bug.
Description
•