Closed Bug 879152 Opened 8 years ago Closed 8 years ago

B2G MMS: Set the delivery status to error when retrieveMMS fail.

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24
blocking-b2g leo+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: ctai, Assigned: ctai)

References

Details

Attachments

(1 file, 2 obsolete files)

We need to set the delivery status to error when retrieveMMS fail. It will cause we can't manually retrieve in second time.
Attached patch Patch v1.0 (obsolete) — Splinter Review
Attachment #757836 - Flags: review?(gene.lian)
This should be a leo+ bug. It will cause we can't manually retrieve MMS in second time.
blocking-b2g: --- → leo?
Comment on attachment 757836 [details] [diff] [review]
Patch v1.0

Review of attachment 757836 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/ril/MmsService.js
@@ +1525,5 @@
>        // For X-Mms-Report-Allowed
>        let wish = aMessageRecord.headers["x-mms-delivery-report"];
>        let responseNotify = function responseNotify(mmsStatus, retrievedMsg) {
>          // If the mmsStatus is still MMS_PDU_STATUS_DEFERRED after retry,
>          // we should not store it into database.

// If the mmsStatus is still MMS_PDU_STATUS_DEFERRED after retry,
// we should not store it into database and update its delivery
// status to 'error'.

@@ +1529,5 @@
>          // we should not store it into database.
>          if (MMS.MMS_PDU_STATUS_RETRIEVED !== mmsStatus) {
>            if (DEBUG) debug("RetrieveMessage fail after retry.");
>            aRequest.notifyGetMessageFailed(Ci.nsIMobileMessageCallback.INTERNAL_ERROR);
> +          // Retrieved fail after retry, so we update the delivery status in DB.

We don't need this comment and please merge into the above-mentioned.

@@ +1534,5 @@
> +          gMobileMessageDatabaseService.setMessageDelivery(aMessageId,
> +                                                           null,
> +                                                           null,
> +                                                           DELIVERY_STATUS_ERROR,
> +                                                           null);

This is good but not right. Please put aRequest.notifyGetMessageFailed(...) in the callback of .setMessageDelivery(...).
Attachment #757836 - Flags: review?(gene.lian) → review-
Attached patch Patch v1.1 (obsolete) — Splinter Review
Attachment #757836 - Attachment is obsolete: true
Attached patch Patch v1.2Splinter Review
Attachment #757858 - Attachment is obsolete: true
Attachment #757860 - Flags: review?(gene.lian)
Attachment #757860 - Flags: review?(gene.lian) → review+
https://hg.mozilla.org/mozilla-central/rev/beca3bdbc023
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
blocking-b2g: leo? → leo+
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.