87916 - non-matching new master passwords disable the ok button

Status: RESOLVED WORKSFORME

(Core Graveyard :: Security: UI, enhancement, P3)

Description

[Stephane Saux]

To reproduce:
prefs->security and privacy->Master pwd->change password
enter your old password
enter "abcdefg"
enter "abcdeff"
they look the same but are different, but you can't click on ok. I suspect that
many people are not going to figure out that they mistyped their new password
and will believe that they're stuck.

Comment 1

[Stephane Saux]

-> javi
p1
target 2.0

Comment 2

[Stephane Saux]

I'm proposing the following improvement:
The ok button is only disabled when the lengths of the two new password fields
differ.
When we actually try to set the passwork is when we check for equality.
This allows us to alert the user that the two fields do not match. There is no
way to do that now in the above case.

See attachment.

Comment 3

[Stephane Saux]

Attachment: proposed patch. Not tested.

Comment 4

[Javier Delgadillo]

So are you not checking to make sure the 2 new passwords are the same?

What benefit does this give us?

Comment 5

[Stephane Saux]

P3
target -> 2.1 for evaluation.

Comment 6

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 7

[Stephane Saux]

removing nsenterprise keyword from PSM bugs with target milestone of future.

Comment 8

[John Unruh]

Mass assigning QA to ckritzer.

Comment 9

[Kai Engert [:KaiE:]]

Could we enhance the "change password dialog" to display an additional text label.

If they match, all is fine.

If they do no match, we show an additinal label, saying "passwords do not match".

Comment 10

[Nelson Bolyard (seldom reads bugmail)]

Mass reassign Javi's old PSM bugs to nobody

Comment 11

[timeless]

kaie: we could replace either "password quality meter" or the entire indicator with "passwords do not match"....