A reset() when not customizing throws off the overflowable navbar (in some cases?)

RESOLVED WONTFIX

Status

()

Firefox
Toolbars and Customization
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: Gijs, Assigned: jaws)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M7])

I end up with a chevron that wasn't there before, which shows no content (probably because the navbar code is sticking hidden items, like the social stuff, in there?). I'm not sure why there's even an overflow event posted; the items should fit fine after a reset(). :-\


STR:
1. Open UX.
(if necessary, open customization mode, click "restore defaults")
2. Open browser console.
3. Execute: window.CustomizableUI.reset()

AR:
Chevron appears, no items are shown in its panel (on OS X Lion, the chevron also has a weird icon?)

ER:
No chevron.
Alexander Limi was also reporting oddness: http://cl.ly/image/160M1O1k230u

Not sure what's going on here, but it'd be good if we could fix some of this for M7, even better if it wouldn't be quirky for the user reviews...
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Whiteboard: [Australis:M7]
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Whiteboard: [Australis:M7] → [Australis:M?]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Whiteboard: [Australis:M?] → [Australis:M7]
<jaws> Gijs: is there an actual use case for fixing bug 879223? when would a user open the scratchpad and run reset?
<Gijs> jaws: oh, I just gave usable STR
<jaws> or maybe that's just the easiest way to repro this bug? i know how to fix it, but i'm not sure it is worth the churn
<Gijs> jaws: actual use cases would be add-ons doing stuff and not checking if we're in customization mode.
<jaws> we expect addons to call reset?
<Gijs> I suppose reset isn't that useful, that's true.
<Gijs> Sorry, I filed a similar bug about the add/move/remove APIs
<jaws> ok no problem. i'll close it out then
<Gijs> I mean, in fact, we have two reset calls.
<Gijs> one on CustomizableUI, one on CustomizeMode
<Gijs> ideally, we should have only one exposed, and one that Just Worked.
<Gijs> But yeah.
<Gijs> perfect worlds don't exist.
<Gijs> yada yada
<jaws> yeah weird, but ok
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.